From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753089AbdLHLv5 (ORCPT ); Fri, 8 Dec 2017 06:51:57 -0500 Received: from ozlabs.org ([103.22.144.67]:52101 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752595AbdLHLvw (ORCPT ); Fri, 8 Dec 2017 06:51:52 -0500 From: Michael Ellerman To: Balbir Singh , Colin King Cc: Benjamin Herrenschmidt , Paul Mackerras , "open list\:LINUX FOR POWERPC \(32-BIT AND 64-BIT\)" , kernel-janitors@vger.kernel.org, "linux-kernel\@vger.kernel.org" Subject: Re: [PATCH] powerpc/xmon: use ARRAY_SIZE on various array sizing calculations In-Reply-To: References: <20171207110134.22566-1-colin.king@canonical.com> Date: Fri, 08 Dec 2017 22:51:50 +1100 Message-ID: <87efo5h1yh.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Balbir Singh writes: > On Thu, Dec 7, 2017 at 10:01 PM, Colin King wrote: >> From: Colin Ian King >> >> Use the ARRAY_SIZE macro on several arrays to determine their size. >> Improvement suggested by coccinelle. > > This file is taken from binutils and re-licensed. Keeping the file > as-is helps apply newer patches easily on top as opposed to redoing > the changes. I would prefer not to move to ARRAY_SIZE and stick to > what's already in the file. Yep. Thanks but no thanks on this one Colin. Is there a checkpatch blacklist anywhere? So we don't keep discovering things in this file that need to be fixed? cheers