From: Michael Ellerman <mpe@ellerman.id.au>
To: Fathi Boudra <fathi.boudra@linaro.org>,
linux-kselftest@vger.kernel.org, Shuah Khan <shuah@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>,
Fathi Boudra <fathi.boudra@linaro.org>
Subject: Re: [PATCH] selftests: gpio: fix Makefile
Date: Tue, 28 Mar 2017 14:00:45 +1100 [thread overview]
Message-ID: <87efxiayw2.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20170324115527.26472-1-fathi.boudra@linaro.org>
Fathi Boudra <fathi.boudra@linaro.org> writes:
> diff --git a/tools/testing/selftests/gpio/Makefile b/tools/testing/selftests/gpio/Makefile
> index 205e4d10e085..714f1f7df04d 100644
> --- a/tools/testing/selftests/gpio/Makefile
> +++ b/tools/testing/selftests/gpio/Makefile
> @@ -1,23 +1,24 @@
> +CFLAGS += -O2 -g -std=gnu99 -Wall
> +CFLAGS += -I../../../../include/uapi/ -I../../../../include/
Those are kernel headers, they *might* work in userspace but they're not
designed to.
Use the exported headers:
CFLAGS += -I../../../../usr/include
If they're not there, then the user can install them, or fall back to
the system headers.
> +CFLAGS += $(shell pkg-config --cflags mount)
> +LDLIBS += $(shell pkg-config --libs mount)
What if pkg-config isn't installed?
cheers
next prev parent reply other threads:[~2017-03-28 3:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 11:55 Fathi Boudra
2017-03-28 3:00 ` Michael Ellerman [this message]
2017-03-28 4:15 ` Fathi Boudra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efxiayw2.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=bamvor.zhangjian@linaro.org \
--cc=fathi.boudra@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®