From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752081AbdA3LSu (ORCPT <rfc822;w@1wt.eu>);
        Mon, 30 Jan 2017 06:18:50 -0500
Received: from ozlabs.org ([103.22.144.67]:39387 "EHLO ozlabs.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751454AbdA3LSk (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 30 Jan 2017 06:18:40 -0500
From: Michael Ellerman <mpe@ellerman.id.au>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Michael Neuling <mikey@neuling.org>,
        Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
        "Shreyas B. Prabhu" <shreyasbp@gmail.com>,
        Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>,
        Stewart Smith <stewart@linux.vnet.ibm.com>,
        Balbir Singh <bsingharora@gmail.com>,
        "Oliver O'Halloran" <oohall@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux PM <linux-pm@vger.kernel.org>,
        "devicetree\@vger.kernel.org" <devicetree@vger.kernel.org>,
        Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v6 3/5] cpuidle:powernv: Add helper function to populate powernv idle states.
In-Reply-To: <CAJZ5v0j_vzsaNeYNBmKs3oMnXyVHF_3chRjeTEwQA_k0TDc3Nw@mail.gmail.com>
References: <1485333389-5752-1-git-send-email-ego@linux.vnet.ibm.com> <1485333389-5752-4-git-send-email-ego@linux.vnet.ibm.com> <871svlxl7w.fsf@concordia.ellerman.id.au> <CAJZ5v0j_vzsaNeYNBmKs3oMnXyVHF_3chRjeTEwQA_k0TDc3Nw@mail.gmail.com>
User-Agent: Notmuch/0.21 (https://notmuchmail.org)
Date: Mon, 30 Jan 2017 22:17:50 +1100
Message-ID: <87efzkx0dd.fsf@concordia.ellerman.id.au>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

"Rafael J. Wysocki" <rafael@kernel.org> writes:

> On Mon, Jan 30, 2017 at 4:47 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>> "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> writes:
>>
>>> From: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
>>>
>>> In the current code for powernv_add_idle_states, there is a lot of code
>>> duplication while initializing an idle state in powernv_states table.
>>>
>>> Add an inline helper function to populate the powernv_states[] table
>>> for a given idle state. Invoke this for populating the "Nap",
>>> "Fastsleep" and the stop states in powernv_add_idle_states.
>>>
>>> Acked-by: Balbir Singh <bsingharora@gmail.com>
>>> Signed-off-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
>>> ---
>>>  drivers/cpuidle/cpuidle-powernv.c | 89 +++++++++++++++++++++++----------------
>>>  include/linux/cpuidle.h           |  1 +
>>
>> I was going to merge this, but I see you've touched cpuidle.h, so I feel
>> like I should get an ACK from the cpuidle folks.
>>
>> It's a fairly uncontroversial change, but it's their API.
>
> OK, please add an ACK from me to it then.

Thanks.

cheers