From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759605AbcHEJju (ORCPT ); Fri, 5 Aug 2016 05:39:50 -0400 Received: from ozlabs.org ([103.22.144.67]:58303 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759383AbcHEJjr convert rfc822-to-8bit (ORCPT ); Fri, 5 Aug 2016 05:39:47 -0400 From: Michael Ellerman To: Christophe Leroy , Alessio Igor Bogani , Scott Wood Cc: Benjamin Herrenschmidt , Paul Mackerras , LKML , linuxppc-dev@lists.ozlabs.org, stable@vger.kernel.org, antoine.blangy@c-s.fr, segher@kernel.crashing.org Subject: Re: [PATCH v2] powerpc/32: fix csum_partial_copy_generic() In-Reply-To: References: <20160802080705.69A9F1A2394@localhost.localdomain> <1470282813.25630.242.camel@buserror.net> <87shujitxx.fsf@concordia.ellerman.id.au> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Fri, 05 Aug 2016 19:38:23 +1000 Message-ID: <87eg63imi8.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christophe Leroy writes: > Le 05/08/2016 à 08:57, Michael Ellerman a écrit : >> Alessio Igor Bogani writes: >>> On 4 August 2016 at 05:53, Scott Wood wrote: >>>> On Tue, 2016-08-02 at 10:07 +0200, Christophe Leroy wrote: >>>>> commit 7aef4136566b0 ("powerpc32: rewrite csum_partial_copy_generic() >>>>> based on copy_tofrom_user()") introduced a bug when destination >>>>> address is odd and initial csum is not null >>>>> > > The purpose of this patch was not to address Alessio's issue, but to fix > a huge issue on checksum calculation which induces breakdown of TCP > connections. > > I think it is worth commiting it upstream and on impacted stable > releases, allthought we don't have yet identified the issue Alessio's has. OK. I'll put it back into fixes on Monday if I haven't heard anything further. cheers