From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752050AbcGRT7o (ORCPT ); Mon, 18 Jul 2016 15:59:44 -0400 Received: from mail.savoirfairelinux.com ([208.88.110.44]:54976 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751013AbcGRT7l (ORCPT ); Mon, 18 Jul 2016 15:59:41 -0400 From: Vivien Didelot To: Andrew Lunn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH v2 net-next v2 12/12] net: dsa: mv88e6xxx: add support for DSA ageing time In-Reply-To: <20160718193253.GJ31103@lunn.ch> References: <20160718184628.13103-1-vivien.didelot@savoirfairelinux.com> <20160718184628.13103-13-vivien.didelot@savoirfairelinux.com> <20160718191644.GG31103@lunn.ch> <87d1malpcd.fsf@ketchup.mtl.sfl> <20160718193253.GJ31103@lunn.ch> User-Agent: Notmuch/0.22 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-unknown-linux-gnu) Date: Mon, 18 Jul 2016 15:59:38 -0400 Message-ID: <87eg6q3efp.fsf@ketchup.mtl.sfl> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew Lunn writes: >> Nope, the bridge ageing time is not per-port, even though switchdev ops >> are per-port by design. This is a switch-wide attribute. > > So you are saying the core is doing all the reference counting, etc, > when swapping between fast and slow ageing? I don't see how checking for the fastest ageing time would fix support for multiple bridges... I think that would make the code much more complex for a small value. Multiple logical bridges on top of a single physical switch is still a tricky topic. Maybe we can keep it simple for the moment with this switch-wide set_ageing_time operation, and later add a patch for the DSA layer to cache and elect the ageing time per-port or per-bridge. Thanks, Vivien