From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751384AbcEJRGT (ORCPT ); Tue, 10 May 2016 13:06:19 -0400 Received: from anholt.net ([50.246.234.109]:35585 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750978AbcEJRGS (ORCPT ); Tue, 10 May 2016 13:06:18 -0400 From: Eric Anholt To: Robert Foss , daniel.vetter@ffwll.ch, airlied@linux.ie, aniel.vetter@ffwll.ch, fengguang.wu@intel.com, maarten.lankhorst@linux.intel.com, julia.lawall@lip6.fr, alexander.deucher@amd.com, daniels@collabora.com, derekf@osg.samsung.com, varadgautam@gmail.com Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] drm/vc4: Return -EBUSY if there's already a pending flip event. In-Reply-To: <5731FFA8.8040304@collabora.com> References: <1462297700-17491-1-git-send-email-robert.foss@collabora.com> <8737pzlzfr.fsf@eliezer.anholt.net> <5731FFA8.8040304@collabora.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 10 May 2016 10:06:13 -0700 Message-ID: <87eg99yha2.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Robert Foss writes: > On 2016-05-03 03:22 PM, Eric Anholt wrote: >> robert.foss@collabora.com writes: >> >>> From: Robert Foss >>> >>> As per the documentation in drm_crtc.h, atomic_commit should return >>> -EBUSY if an asycnhronous update is requested and there is an earlier >>> update pending. >>> >>> Note: docs cited here are drm_crtc.h, and the whole quote is: >>> >>> * - -EBUSY, if an asynchronous updated is requested and there is >>> * an earlier updated pending. Drivers are allowed to support a queue >>> * of outstanding updates, but currently no driver supports that. >>> * Note that drivers must wait for preceding updates to complete if a >>> * synchronous update is requested, they are not allowed to fail the >>> * commit in that case. >>> >>> Signed-off-by: Robert Foss >> >> This looks good to me. Let's give it a few days on the list for any >> other KMS folks to catch anything. >> > > I haven't seen any further feedback regarding this patch. > Does anyone have objections to it being merged? I merged it to drm-vc4-next last night, actually :) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJXMhUFAAoJELXWKTbR/J7oIk4P/iT5HdiBi5VLiq6XGgm6b3j7 aU5hsjzz0UpfvA7NGnJECvU+Ucrlz2cqlgkm2PzxQUtQCYOHg2hU28EDNYYNJyEt HjCg38icd7N6gvUNStPQWi+PWZZTD++7AajeYTJXjTsfzLDjnDCAJBjcrKoL0PDV apCopZfL8Wu6ZBYYqk+4MR8vfrmPEPn1c43j5aDIkddyGurI1fcoArs2iy8CyVQk /BvnX7K77j/otL7rB8I+GD3qrQFrAJy43OJHRMgiY9SnfuCDDdzjZaDoUX9szbAP VXnhaKzc2iW7eRlP0YJIE3CafSMf8utQr1pVfyN7wH2Wywzednbhcb/7/Tu9eQfd +dMZh2RzbnWc+CuXHksNZiY9VXHMP4XczCTHBgGJr68C+sC3t6VH0e5xOMIl87m7 A9/TWyqFnvECl6FbewCW8Np5V78SFLA7kmJZrObezFEFAs/cdunu5IXb+yY70sbu Q8tUXhX3tBCZaLNrFpyg6NX3DYxCE3HY5t0WOOiPc1tbdmVq4FYUbgO8Pbcmn4RM +ky3w5LHUkULDz97MU1VYRpx0NE4eEdIA4EWfidOluuFnLavYdFYnisA9vYBL5zI gN4i4huRBY158wXUY/R6VthxBqM8JmNli1y2/0hbL7f2S2zjKFB+zcOVy7OrlImy kEn1ms3ua4sGeDG1kxEf =OcOv -----END PGP SIGNATURE----- --=-=-=--