From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752688AbcANH1w (ORCPT <rfc822;w@1wt.eu>);
	Thu, 14 Jan 2016 02:27:52 -0500
Received: from mail-wm0-f68.google.com ([74.125.82.68]:36833 "EHLO
	mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751799AbcANH1t (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 14 Jan 2016 02:27:49 -0500
From: Peter Korsgaard <peter@korsgaard.com>
To: "Yang\, Wenyou" <Wenyou.Yang@atmel.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        "Rob Herring" <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        "Kumar Gala" <galak@codeaurora.org>,
        Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        "devicetree\@vger.kernel.org" <devicetree@vger.kernel.org>,
        "Ferre\, Nicolas" <Nicolas.FERRE@atmel.com>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Javier Martinez Canillas <javier@dowhile0.org>,
        Lee Jones <lee.jones@linaro.org>,
        "linux-arm-kernel\@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/2] regulator: act8945a: add regulator driver for ACT8945A
References: <1452586629-1117-1-git-send-email-wenyou.yang@atmel.com>
	<1452586629-1117-2-git-send-email-wenyou.yang@atmel.com>
	<87oacp5zl7.fsf@dell.be.48ers.dk>
	<B256D81BAE5131468A838E5D7A243641D63EBC6E@penmbx01>
Date: Thu, 14 Jan 2016 08:27:45 +0100
In-Reply-To: <B256D81BAE5131468A838E5D7A243641D63EBC6E@penmbx01> (Wenyou
	Yang's message of "Thu, 14 Jan 2016 01:23:39 +0000")
Message-ID: <87egdk39ji.fsf@dell.be.48ers.dk>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>>>>> "Yang," == Yang, Wenyou <Wenyou.Yang@atmel.com> writes:

 >> Isn't the regulator part of the act8945a identical to act8865? Can't we just use the
 >> existing act8865-regulator.c driver? (E.G. support 8865 variant in the mfd driver,
 >> but only register the regulator sub device?)

 > Yes, the regulator part of the act8945a is identical to act8865.

 > But the act8865-regulator driver is a struct i2c_driver, and the mfd
 > sub-device driver is a platform_driver driver, it is not easy to use
 > it.

But the mfd driver could support the act8865 variant as well (by only
registering the regulator mfd cell).

-- 
Venlig hilsen,
Peter Korsgaard