From: Eric Anholt <eric@anholt.net>
To: Lee Jones <lee@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Stephen Warren <swarren@wwwdotorg.org>,
linux-clk@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org>,
Mike Turquette <mturquette@linaro.org>
Subject: Re: [PATCH v3 1/7] dt/bindings: Add binding for the Raspberry Pi clock provider
Date: Tue, 07 Jul 2015 13:13:48 -0700 [thread overview]
Message-ID: <87egkj914z.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <20150609100326.GQ2982@x1>
[-- Attachment #1: Type: text/plain, Size: 2473 bytes --]
Lee Jones <lee@kernel.org> writes:
> If I were the Clock Maintainer, I would have probably missed this
> patch. You _must_ intimate which subsystem you are submitting to.
>
>> The hardware clocks are not controllable by the ARM, so we have to
>> make requests to the firmware to do so from the VPU side. This will
>> let us replace fixed clocks in our DT with actual clock control (and
>> correct frequency information).
>>
>> v2: Include the dt-bindings header in this commit instead of the next
>> one. Make the clock indices match the firmware clock IDs. Rename
>> the binding's compat string. Move the firmware phandle to be
>> under a vendor-specific namespace.
>>
>> Signed-off-by: Eric Anholt <eric@anholt.net>
>> ---
>> .../clock/raspberrypi,bcm2835-firmware-clocks.txt | 25 ++++++++++++++++++++++
>> include/dt-bindings/clk/raspberrypi.h | 23 ++++++++++++++++++++
>> 2 files changed, 48 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/clock/raspberrypi,bcm2835-firmware-clocks.txt
>> create mode 100644 include/dt-bindings/clk/raspberrypi.h
>>
>> diff --git a/Documentation/devicetree/bindings/clock/raspberrypi,bcm2835-firmware-clocks.txt b/Documentation/devicetree/bindings/clock/raspberrypi,bcm2835-firmware-clocks.txt
>> new file mode 100644
>> index 0000000..0972602
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/raspberrypi,bcm2835-firmware-clocks.txt
>> @@ -0,0 +1,25 @@
>> +Raspberry Pi firmware clock provider.
>> +
>> +The Raspberry Pi architecture doesn't provide direct access to the
>> +CLOCKMAN peripheral from the ARM side, so Linux has to make requests
>> +to the VPU firmware to program them.
>> +
>> +This binding uses the common clock binding:
>> +Documentation/devicetree/bindings/clock/clock-bindings.txt
>> +
>> +Required properties:
>> +- compatible: Should be "raspberrypi,bcm2835-firmware-clocks"
>> +
>> +- #clock-cells: Shall have value <1>. The permitted clock-specifier
>> + values can be found in
>> + include/dt-bindings/clk/raspberrypi.h.
>> +
>> +- raspberrypi,firmware: Phandle to the firmware driver node.
>
> I think 'firmware' is a candidate for a generic phandle name.
Stephen Warren asked in the last version that I change it from
"firmware" to "raspberrypi,firmware", which made sense to me since we're
not some core infrastructure using these references. Which should it
be?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2015-07-07 20:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 23:58 Eric Anholt
2015-06-08 23:58 ` [PATCH v3 2/7] ARM: bcm2835: Add a Raspberry Pi-specific clock driver Eric Anholt
2015-06-09 1:56 ` Stephen Warren
2015-06-09 9:56 ` Lee Jones
2015-06-08 23:58 ` [PATCH v3 3/7] ARM: bcm2835: Add DT for the firmware clocks driver Eric Anholt
2015-06-08 23:58 ` [PATCH v3 4/7] ARM: bcm2835: Drop never-used clock-frequency property of uart0 Eric Anholt
2015-06-08 23:58 ` [PATCH v3 5/7] ARM: bcm2835: Drop the fixed sys_pclk Eric Anholt
2015-06-08 23:58 ` [PATCH v3 6/7] ARM: bcm2835: Use the RPi firmware clocks for uart Eric Anholt
2015-06-08 23:59 ` [PATCH v3 7/7] ARM: bcm2835: Tie SPI clock to the core clock rate Eric Anholt
2015-06-09 0:03 ` [PATCH v3 1/7] dt/bindings: Add binding for the Raspberry Pi clock provider Eric Anholt
2015-06-09 10:03 ` Lee Jones
2015-07-07 20:13 ` Eric Anholt [this message]
2015-07-24 15:30 ` Lee Jones
2015-07-28 2:53 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87egkj914z.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mturquette@linaro.org \
--cc=sboyd@codeaurora.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®