From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751519AbbFYIEV (ORCPT ); Thu, 25 Jun 2015 04:04:21 -0400 Received: from mail-la0-f47.google.com ([209.85.215.47]:34227 "EHLO mail-la0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751226AbbFYIEF (ORCPT ); Thu, 25 Jun 2015 04:04:05 -0400 From: Rasmus Villemoes To: Michal Marek Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 1/4] scripts: add stackusage script Organization: D03 References: <1434849046-19920-1-git-send-email-linux@rasmusvillemoes.dk> <1434849046-19920-2-git-send-email-linux@rasmusvillemoes.dk> <558964EE.7090009@suse.cz> X-Hashcash: 1:20:150625:linux-kernel@vger.kernel.org::TywI1towX9eMmHQJ:0000000000000000000000000000000001hFS X-Hashcash: 1:20:150625:linux-kbuild@vger.kernel.org::Pnhz4NKSLqjTiKa4:0000000000000000000000000000000002AWA X-Hashcash: 1:20:150625:mmarek@suse.cz::i0WLHKsO2FgfUHYl:000B2f6 Date: Thu, 25 Jun 2015 10:04:00 +0200 In-Reply-To: <558964EE.7090009@suse.cz> (Michal Marek's message of "Tue, 23 Jun 2015 15:53:50 +0200") Message-ID: <87egl08b9r.fsf@rasmusvillemoes.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 23 2015, Michal Marek wrote: > > EXTRA_CFLAGS is reserved for use by Makefiles, please use KCFLAGS > instead. Will do, thanks. Maybe Documentation/SubmitChecklist and Documentation/development-process/4.Coding wants to be updated. > I wonder whether it worked at all, because EXTRA_CFLAGS is > reset by scripts/Makefile.build. It did indeed work, but only because I passed the setting on the make command line and not via the environment. I think one needs an override directive to actually override the settings from the command line: $ cat Makefile VAR1 := a1 VAR2 := a2 override VAR3 := a3 override VAR4 := a4 all: @echo $(VAR1) $(VAR2) $(VAR3) $(VAR4) $ VAR1=b1 VAR3=b3 make VAR2=b2 VAR4=b4 all a1 b2 a3 a4