From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933746AbbBDMII (ORCPT ); Wed, 4 Feb 2015 07:08:08 -0500 Received: from mail-la0-f43.google.com ([209.85.215.43]:39796 "EHLO mail-la0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932316AbbBDMIC (ORCPT ); Wed, 4 Feb 2015 07:08:02 -0500 From: Rasmus Villemoes To: Nicholas Mc Guire Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Abel Moyo , Larry Finger Subject: Re: [PATCH] staging: rtl8188eu: core: switch with redundant cases Organization: D03 References: <1423047878-5783-1-git-send-email-hofrat@osadl.org> X-Hashcash: 1:20:150204:larry.finger@lwfinger.net::WOeQAkl6gNmAp04X:0000000000000000000000000000000000000AmT X-Hashcash: 1:20:150204:linux-kernel@vger.kernel.org::hZ/04nP++WF88wIF:0000000000000000000000000000000000VZi X-Hashcash: 1:20:150204:devel@driverdev.osuosl.org::F8uqprquZzo86WbD:0000000000000000000000000000000000024Fw X-Hashcash: 1:20:150204:gregkh@linuxfoundation.org::CwOfQaPgNEm6i6+z:000000000000000000000000000000000004tXn X-Hashcash: 1:20:150204:hofrat@osadl.org::i1kwrAwjIa8aHi4v:07Yx+ X-Hashcash: 1:20:150204:abelmoyo.ab@gmail.com::Buo8irPSOjmdgUJL:00000000000000000000000000000000000000009vg6 Date: Wed, 04 Feb 2015 13:07:59 +0100 In-Reply-To: <1423047878-5783-1-git-send-email-hofrat@osadl.org> (Nicholas Mc Guire's message of "Wed, 4 Feb 2015 06:04:38 -0500") Message-ID: <87egq5c21s.fsf@rasmusvillemoes.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 04 2015, Nicholas Mc Guire wrote: > A few redundant switch cases as well as a redundant if/else > within one of the cases was consolidated to a single call. > The cases are intentionally retained for documentation purposes. > [...] > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c > index 28918201..cd12dd7 100644 > --- a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c > +++ b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c > @@ -484,17 +484,8 @@ void mgt_dispatcher(struct adapter *padapter, struct recv_frame *precv_frame) > /* fall through */ > case WIFI_ASSOCREQ: > case WIFI_REASSOCREQ: > - _mgt_dispatcher(padapter, ptable, precv_frame); > - break; > case WIFI_PROBEREQ: > - if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) > - _mgt_dispatcher(padapter, ptable, precv_frame); > - else > - _mgt_dispatcher(padapter, ptable, precv_frame); It is highly unlikely that a function called check_fwstate has side effects, but it might be nice checking that and making a note in the commit log. Rasmus