mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Oleg Nesterov <oleg@redhat.com>, Prarit Bhargava <prarit@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] modules, lock around setting of MODULE_STATE_UNFORMED
Date: Mon, 13 Oct 2014 16:11:26 +1030	[thread overview]
Message-ID: <87egucedbt.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20141008143743.GA4835@redhat.com>

Oleg Nesterov <oleg@redhat.com> writes:
> On 10/08, Prarit Bhargava wrote:
>>
>> --- a/kernel/module.c
>> +++ b/kernel/module.c
>> @@ -1842,7 +1842,9 @@ static void free_module(struct module *mod)
>>  
>>  	/* We leave it in list to prevent duplicate loads, but make sure
>>  	 * that noone uses it while it's being deconstructed. */
>> +	mutex_lock(&module_mutex);
>>  	mod->state = MODULE_STATE_UNFORMED;
>> +	mutex_unlock(&module_mutex);
>>  
>>  	/* Remove dynamic debug info */
>>  	ddebug_remove_module(mod->name);
>
> Reviewed-by: Oleg Nesterov <oleg@redhat.com>

Thanks, good catch.

I've cc'd stable too.

Cheers,
Rusty.


      reply	other threads:[~2014-10-13  6:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-08 12:42 Prarit Bhargava
2014-10-08 14:37 ` Oleg Nesterov
2014-10-13  5:41   ` Rusty Russell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87egucedbt.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=prarit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome