From: "Bjørn Mork" <bjorn@mork.no>
To: Hayes Wang <hayeswang@realtek.com>
Cc: <netdev@vger.kernel.org>, <nic_swsd@realtek.com>,
<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>
Subject: Re: [PATCH net-next v2 2/2] r8152: use eth_hw_addr_random
Date: Wed, 03 Sep 2014 10:33:12 +0200 [thread overview]
Message-ID: <87egvtyugn.fsf@nemi.mork.no> (raw)
In-Reply-To: <1394712342-15778-31-Taiwan-albertk@realtek.com> (Hayes Wang's message of "Wed, 3 Sep 2014 10:59:15 +0800")
Hayes Wang <hayeswang@realtek.com> writes:
> + ether_addr_copy(dev->perm_addr, dev->dev_addr);
This isn't strictly necessary. register_netdev() will do it for you as
long as you leave the default addr_assign_type (NET_ADDR_PERM). And you
do.
Bjørn
next prev parent reply other threads:[~2014-09-03 8:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 9:55 [PATCH net-next 0/2] r8152: random MAC address Hayes Wang
2014-09-02 9:55 ` [PATCH net-next 1/2] r8152: change the location of rtl8152_set_mac_address Hayes Wang
2014-09-02 9:55 ` [PATCH net-next 2/2] r8152: use eth_hw_addr_random Hayes Wang
2014-09-02 12:53 ` Sergei Shtylyov
2014-09-03 2:59 ` [PATCH net-next v2 0/2] r8152: random MAC address Hayes Wang
2014-09-03 2:59 ` [PATCH net-next v2 1/2] r8152: change the location of rtl8152_set_mac_address Hayes Wang
2014-09-03 2:59 ` [PATCH net-next v2 2/2] r8152: use eth_hw_addr_random Hayes Wang
2014-09-03 8:33 ` Bjørn Mork [this message]
2014-09-04 8:15 ` [PATCH net-next v3 0/2] r8152: random MAC address Hayes Wang
2014-09-04 8:15 ` [PATCH net-next v3 1/2] r8152: change the location of rtl8152_set_mac_address Hayes Wang
2014-09-04 8:15 ` [PATCH net-next v3 2/2] r8152: use eth_hw_addr_random Hayes Wang
2014-09-05 19:18 ` [PATCH net-next v3 0/2] r8152: random MAC address David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87egvtyugn.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome