Re: [PATCH] missing checks in exec_permission_light()

[Daniel Pittman <daniel@rimspace.net>]

On Tue, 30 Apr 2002, Alexander Viro wrote:
> 	Missing checks added...
> 
> diff -urN C12-0/fs/namei.c C12-current/fs/namei.c
> --- C12-0/fs/namei.c	Tue Apr 30 20:23:38 2002
> +++ C12-current/fs/namei.c	Tue Apr 30 23:37:15 2002
> @@ -324,6 +324,12 @@
>  	if (mode & MAY_EXEC)
>  		return 0;
> 
> +	if ((inode->i_mode & S_IXUGO) && capable(CAP_DAC_OVERRIDE))
> +		return 0;
> +
> +	if (S_ISDIR(inode->i_mode) && capable(CAP_DAC_READ_SEARCH))
> +		return 0;
> +
>  	return -EACCES;
>  }

Looking at this it seems that it would explain the odd set of errors I
got reported during bootup under 2.5.12 -- a set of "permission denied"
errors from find(1) where, under 2.5.6, none had occurred.

These were on directories that are not owner by root, with the process
running as root.

I can look deeper into the problem, though, if you don't think that this
is the cause of it.

Regards,
        Daniel

-- 
It is easier to build strong children than to repair broken men.
        -- Frederick Douglas