From: Timur Tabi <timur@kernel.org>
To: Wang Hai <wanghai38@huawei.com>, davem@davemloft.net, kuba@kernel.org
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net] net: qcom/emac: Fix missing clk_disable_unprepare() in error path of emac_probe
Date: Thu, 6 Aug 2020 09:23:54 -0500 [thread overview]
Message-ID: <87f41175-689e-f198-aaf6-9b9f04449ed8@kernel.org> (raw)
In-Reply-To: <20200806140647.43099-1-wanghai38@huawei.com>
On 8/6/20 9:06 AM, Wang Hai wrote:
> In emac_clks_phase1_init() of emac_probe(), there may be a situation
> in which some clk_prepare_enable() succeed and others fail.
> If emac_clks_phase1_init() fails, goto err_undo_clocks to clean up
> the clk that was successfully clk_prepare_enable().
Good catch, however, I think the proper fix is to fix this in
emac_clks_phase1_init(), so that if some clocks fail, the other clocks
are cleaned up and then an error is returned.
next prev parent reply other threads:[~2020-08-06 17:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 14:06 Wang Hai
2020-08-06 14:23 ` Timur Tabi [this message]
2020-08-07 1:54 ` wanghai (M)
2020-08-07 13:38 ` Timur Tabi
2020-08-10 3:01 ` wanghai (M)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87f41175-689e-f198-aaf6-9b9f04449ed8@kernel.org \
--to=timur@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wanghai38@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®