From: David Laight <David.Laight@ACULAB.COM>
To: 'Joe Perches' <joe@perches.com>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>, LKML <linux-kernel@vger.kernel.org>
Subject: RE: list iterator spacing: clang-format vs checkpatch
Date: Tue, 18 Jan 2022 09:27:57 +0000 [thread overview]
Message-ID: <87f5fe31ee8748658ca5849cdcad832e@AcuMS.aculab.com> (raw)
In-Reply-To: <e67388e4bdd25ca5ccb4cf20df0527d82ba31277.camel@perches.com>
From: Joe Perches
> Sent: 17 January 2022 18:05
>
> On Mon, 2022-01-17 at 13:47 +0100, Jason A. Donenfeld wrote:
> > Hey again,
>
> Rehi.
>
> > Four years later I went through basically the same motions: "oh hey I
> > should clean this up", "I'll start with clang format", "oh cool it
> > adds spaces before the iterator paren so it looks like a normal for
> > loop to me", "that seems so reasonable; I love clang format", "oh no
> > checkpatch.pl complains; I hope it's wrong", "I wonder if anybody has
> > thought about this before", "oh, look, I asked about this already in
> > 2018."
Personally I think it should look like a #define expansion, not
part of the language.
I did notice it in the recent patch - and though it looked wrong.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2022-01-18 9:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 2:00 Jason A. Donenfeld
2018-10-08 7:31 ` Miguel Ojeda
2018-10-08 15:40 ` Joe Perches
2018-10-08 16:01 ` Miguel Ojeda
2018-10-08 16:06 ` Jason A. Donenfeld
2022-01-17 12:47 ` Jason A. Donenfeld
2022-01-17 18:05 ` Joe Perches
2022-01-17 21:41 ` Miguel Ojeda
2022-01-18 4:25 ` Joe Perches
2022-01-18 9:27 ` David Laight [this message]
2022-01-17 21:41 ` Miguel Ojeda
2022-01-22 13:16 ` Miguel Ojeda
2022-04-21 23:53 ` Brian Norris
2022-04-22 10:57 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87f5fe31ee8748658ca5849cdcad832e@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=Jason@zx2c4.com \
--cc=andrew@lunn.ch \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome