From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Mark Brown <broonie@kernel.org>
Cc: Markus Elfring <Markus.Elfring@web.de>,
Yang Zi <2959243019@qq.com>,
kernel-janitors@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: max8649: Fix NULL pointer dereference in probe
Date: Wed, 26 Aug 2026 14:58:18 -0400 (EDT) [thread overview]
Message-ID: <87f6e08c-97e2-cdde-1349-2a95e8e55ad3@crashcourse.ca> (raw)
In-Reply-To: <0f550622-5a14-47d5-976e-44a20495d751@sirena.org.uk>
[-- Attachment #1: Type: text/plain, Size: 531 bytes --]
On Wed, 26 Aug 2026, Mark Brown wrote:
> On Wed, Aug 26, 2026 at 08:36:29PM +0200, Markus Elfring wrote:
> > …
> > > Add a check and return -EINVAL when pdata is NULL.
>
> > How do you think about to perform this data processing
> > directly after the variable assignment?
>
> Feel free to ignore Markus, he has a long history of sending
> unhelpful review comments and continues to ignore repeated requests
> to stop.
I've recently wondered how easy it would be to write a "Markus
Elfring Random Suggestion Generator".
rday
prev parent reply other threads:[~2026-08-26 19:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 9:01 Yang Zi
2026-08-26 13:34 ` Mark Brown
2026-08-26 18:36 ` Markus Elfring
2026-08-26 18:39 ` Mark Brown
2026-08-26 18:58 ` Robert P. J. Day [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87f6e08c-97e2-cdde-1349-2a95e8e55ad3@crashcourse.ca \
--to=rpjday@crashcourse.ca \
--cc=2959243019@qq.com \
--cc=Markus.Elfring@web.de \
--cc=broonie@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®