From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C7F63D6682 for ; Tue, 16 Jun 2026 08:48:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781599696; cv=none; b=r+iKLQM/pSHyu3IabDnh/4r1IcFUMNbiFS32RvOzN7Xy6W1dgHcnHvBpqnExAUpbEFOfxC0WWUfreokw90m9mHRy5VIn0Zx5dEpXxKd1IRcTM4nqU4a1sEYAV6RQYU3EK3944Yui5iVHR3LdmDQyCZyBfcHb3RXkbAba77cxles= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781599696; c=relaxed/simple; bh=/59QdiMwV7etkDOMxpG6vuGX6DwnCz+agdBE0NV8LeQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=rwGFcTYbQcppJTJBYzrT/dQ3ZtufHWqvnMAhBShtAkoEc6EzZMp2tG9WRzkvLCZCnjaNpd93u4oICVOQ5s5ZfDZHSF6fIrQtgBMSxkjWP4oAcTEF9TEvnzb+74N0JVy51UDvpACBv2tnzTVkHFE1/C645cbYSx1bb0R1ffYsC5Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=io1gXTzr; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Hcc+k+cG; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="io1gXTzr"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Hcc+k+cG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781599694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FLV3dwnxfsWUtnrYURiK7yDU0xjatBfMX7/p7eIbm8Y=; b=io1gXTzr8JtVpynPRBtw+UaQJ9+vJL82yh9TOQF5lYSEzxQdVmNXtBht2DDZiqmhu4l+/v jjEMgp8yI5aiWdxgqVcx05E67jldgc9c+9x5nlrmmMsJvxxMPROIhmiEd6hYAu3KP54pD0 ZMBKcYRdCgFcrTP3C+wKeDJKJZB4OOc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-670-CrgqpK9mNJyQ2t_VGDFE9A-1; Tue, 16 Jun 2026 04:48:13 -0400 X-MC-Unique: CrgqpK9mNJyQ2t_VGDFE9A-1 X-Mimecast-MFC-AGG-ID: CrgqpK9mNJyQ2t_VGDFE9A_1781599692 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-49221de4ed4so20064485e9.0 for ; Tue, 16 Jun 2026 01:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1781599692; x=1782204492; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=FLV3dwnxfsWUtnrYURiK7yDU0xjatBfMX7/p7eIbm8Y=; b=Hcc+k+cGNWOoqEiwCpcLdxpZW0NoUiXtImjTnCdGCoLWbDzpKMZkOhsovpXsyJEICR QmVkRe3dOpTM51yYQ5ExcUBSkf6ilZjj9SRqduyl9fICnkCv+6gyN6jHQDYYd0TohKIh 5jxRUybuVtejes+SIY3wUf6B15CCPfepkPalTXtEmtV/4BARvLpJTnykyBnVLERRqNMN kLk/vgrLMktUIaFDKcCY6ArxsWrPZz78p4pIXjjHDs5icb34y05W5ZQvyHIUHYhC20fY ocMCNtCcc+cGOLmmXhlFW22X/hBoSvHo1mQsdsRVCdHvF+qALDpMzH62ZrG0OKN9lLcz RBig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781599692; x=1782204492; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FLV3dwnxfsWUtnrYURiK7yDU0xjatBfMX7/p7eIbm8Y=; b=QPcOCR/x7wjPjqpHPL+UU930p8F1hAbK1MHjxqGum6ATDHTqpShWWinTxGyxhZ0gMe LG2g80/FQjviBh0isSuodDdBF4SarKp4dpGZsHTadIkz7qXC0jG90cCkPRfaqCYckLMO Jp9Lb5HEqixwf3b42+j+tnN/pKSB1nCubdGmec3A3GNeDfT8E2K9i7IOFQX/8XexG3zk vpbdJPVL8p4ECnzxm66H12uVF0IQq4vqeX0Neb0azyeq8Tg8/d2FRpZ30b60wADZrQjA Ab7VQ6nUBTRf+62CxfVadO0h6BxSvGK7yFvA2bpN4IGT57+JGUsNU1eS6OUViNRMbocE ZvWg== X-Forwarded-Encrypted: i=1; AFNElJ/6n5+wXiD3KMKo4RnERSfh/Kxz5CfyeXGR9xXh99og2zxWu6H2h8vnIyLBpyo/IfiRFRUnDmj16rQrAhw=@vger.kernel.org X-Gm-Message-State: AOJu0Yxf4bhQGtlW3T3heGgid3KoW+1Yw/bxaQ/q30zGUnSMZiGwk534 PdNYOpgLD70PlO/qL7icpt0FR3TtHP9Q72QPIuTaGg6FH8wyzDdkX9evoKk5GwiWRiFowvo/o7P pk3U8JX3EFhhLs7tL9BDZByWplgsb0yCATBckqz0kRom8z7jt6/1XT6hXyXLoZs9kgg== X-Gm-Gg: Acq92OHPw/by+vieLG2oCtvSxwNDnFS4OOMxYeg5jnUALQwEKv3vZ10LBMdfUYYNfCI ctavB3EiUpQnNZaidrUCQQnkvpKJZE7fS7ZUloxWr6F2cUpR1KxfQla+8PvrucU9cvCYbsPqNzI KDqHzQC4KXuphQBjv8Y/CMMsbsyeqPNS/ag1JANoPaKtl0ZgEcR+tgQOTURk0CCaeCZOC7nsIAX /wNKqRVY0G2fdSz3rigFPO5FSmrcQ6lIe0tr3fwkVBbGOWQ2MYnFBTtCW43t8f5qUU83zc5Wc7G c1/YshE3OFqa2XDby3NgDU2G3tAjntx+Cv96ST/apyAChramuA638k0uWgYvIOAQLo61DNbIH4L ys0tELEMDO1TnzZVVa0Gxp1H3+InJ3W0MoxrAboS5tSIYlyiMDp1Yas4gpWPAowmUSOqcgXAlqb iOfs2k X-Received: by 2002:a05:600c:6749:b0:490:3f7a:108b with SMTP id 5b1f17b1804b1-4922ffa2367mr38343555e9.16.1781599690107; Tue, 16 Jun 2026 01:48:10 -0700 (PDT) X-Received: by 2002:a05:600c:6749:b0:490:3f7a:108b with SMTP id 5b1f17b1804b1-4922ffa2367mr38342815e9.16.1781599689402; Tue, 16 Jun 2026 01:48:09 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49230a4fd31sm42464485e9.4.2026.06.16.01.48.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 01:48:08 -0700 (PDT) From: Javier Martinez Canillas To: Alberto Ruiz via B4 Relay , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Alberto Ruiz Subject: Re: [PATCH 0/4] drm/solomon: batch command sequences for SSD130x/132x/133x init In-Reply-To: <87o6hfzg98.fsf@ocarina.mail-host-address-is-not-set> References: <20260612-ssd-batchcmd-v1-0-c61e5f7c24bc@redhat.com> <87o6hfzg98.fsf@ocarina.mail-host-address-is-not-set> Date: Tue, 16 Jun 2026 10:48:07 +0200 Message-ID: <87fr2mzxa0.fsf@ocarina.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Javier Martinez Canillas writes: > Alberto Ruiz via B4 Relay writes: > > Hello Alberto, > > Thanks for the patches. Nice cleanup! > >> The ssd130x_init(), ssd132x_init(), and ssd133x_init() functions each >> issue long chains of individual ssd130x_write_cmd() calls, each >> followed by its own error check. This is verbose and makes the init >> sequences harder to read and maintain. >> >> This series introduces ssd130x_run_cmd_seq(), which interprets a flat >> byte array of length-prefixed command entries terminated by a zero >> byte, and converts the three init functions to use it. The result is >> a net reduction of ~110 lines, with the hardware programming sequences >> now expressed as compact, declarative tables rather than imperative >> call-and-check chains. >> >> Signed-off-by: Alberto Ruiz >> --- >> Alberto Ruiz (4): >> drm/solomon: add ssd130x_run_cmd_seq() for batch command execution >> drm/solomon: use ssd130x_run_cmd_seq() in ssd130x_init() >> drm/solomon: use ssd130x_run_cmd_seq() in ssd132x_init() >> drm/solomon: use ssd130x_run_cmd_seq() in ssd133x_init() > > For all the patches: > > Reviewed-by: Javier Martinez Canillas > Tested-by: Javier Martinez Canillas > > I'll wait for a few days to merge them, in case someone else have comments. > Pushed to drm-misc (drm-misc-next). Thanks! -- Best regards, Javier Martinez Canillas Core Platforms Red Hat