From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17CF632C331 for ; Tue, 16 Dec 2025 08:35:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765874145; cv=none; b=IvLMhslBroSW2/DRdsFWRBeFRoaLFuHLFJOUN5Ndxn15igoUKzAbPd60Y3GQWV5f9t75UqhZG2iy2+9WfoUr9ZrqXsK12yNIuOB0wKeqDWnmjqbWeFOF2+RJ+A5aVwFsrpst6f+RKfKKl5X8aJNfU08cnxKrmBOenzeg80lXUdo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765874145; c=relaxed/simple; bh=vpiPV/82YEEmxwakE43hgEHuZW8h/NkkD52bh8o/W5A=; h=From:To:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=uwQKp/TiHS9YMQI0KlCvQqAvqhTnVuCvZt+9f2RT+DfTSPpffHSULTkUcMCO9WyPNBl22jYMm16eBRHqon2uGNFnkLBV92rbfVJnKdSJdV+w/bAqulngKKx+nAiAAp4oKhVM6myiP2JNNGMC/6vvi1Cjr+e+RL1vbC4FeYoGgQA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IgB3E25D; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=jlmx80Pz; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IgB3E25D"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="jlmx80Pz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765874133; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=j3yLrcNoJepHFXDHm8iCXLSfgqPyKjEs/VGVHTvzMsM=; b=IgB3E25D6LVuxxpPneLh+FnNwVWBhGwPxmWkjJ+FpmsfAaUfKjuK7QjdBVzsBNqUxYxRBB +PJviOVVPoMxQfced7pt/oGIvduYvvoiN/RljuphxijP6CjtVY+zsNciLWNoo9hoLEcClW 78Gh2eT2yiZaPH4MN9sMb0xE7JAUUqE= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-402-CAve2NR5OliCY6LkiGJKiw-1; Tue, 16 Dec 2025 03:35:31 -0500 X-MC-Unique: CAve2NR5OliCY6LkiGJKiw-1 X-Mimecast-MFC-AGG-ID: CAve2NR5OliCY6LkiGJKiw_1765874131 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-477c49f273fso52825825e9.3 for ; Tue, 16 Dec 2025 00:35:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1765874130; x=1766478930; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :from:to:cc:subject:date:message-id:reply-to; bh=j3yLrcNoJepHFXDHm8iCXLSfgqPyKjEs/VGVHTvzMsM=; b=jlmx80PzYy6UuecZgJldl5H3FzX+o6VhNPMqtE5+BV2F9bewOPGOFSzFKnIK7DXOx+ P3/N+EXO7Zh4xR0zj6EYMI+qq0Y0+et8yd3/lkQMi0WcqciaRfny200aWFbqClRzR99Y JIswceIpGqUfcfEcCq21FKF424WoTZ9BnvRm/XSwT/De7kQcCitKPZmndBy010dhYArd aKfvMc0b7Z0dHTOzrCIJ/DktHd0Stbac+zFC8ptFPnlLN9coRRsPuBFBbL7r8YFUgjMz zXZ17C/H6xI8trnKAVrPVVNx682i225+crO/t8ihkSuJcXJMI8sJ1ed31DSDmHsJwOe6 HLdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765874130; x=1766478930; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=j3yLrcNoJepHFXDHm8iCXLSfgqPyKjEs/VGVHTvzMsM=; b=plKZW9fQH37eMbhwiR6OMOXlM5Ciulg6KHk7oMXca6b9uVhPIJtKrpZPNf4cOoKcNh c9vFuQX/OIkoxLl7qnMD8aSy4C43y4EHuDZP4gp8OAbl1Kfkl0q+To81uFU+EnYUlN8j GfMUM6cFlZM975C+zz5U2UVAnb4mOxwZr8YTJ0Xy8fgVCFSo49xwfMiNPpnOiPgv1j0k SlDMXvv2HNqw7qwhYcgHJd37w18vJFJspy+AMn+1SNj5dgw3pmyIPPiDZy6CQC3d9h4D 5Ak5xQfe8+2QmhW97xpBTEbnPnpkSYCMGcKvkI9F5T56GltjPV3g/ZBtokM2FjIe1TVr Rjsg== X-Forwarded-Encrypted: i=1; AJvYcCUxsKlXtEEbhqE41DzRuwXMBT1GXwaJGE+E6Mb+y6OxMwitU3rjeomgNtXgZvZakd7JhekjGK9vqSfZsE0=@vger.kernel.org X-Gm-Message-State: AOJu0YzVs5Pv15N1CU8LwvGDgtdMv9Rr46EFEedObLoz6Tzv8mEkK0NS 5UpBMERUAb5v835Wh0GsiLoFwLjXMTfYQzb0uUC3vbeMlbDykrI1p7tABp43RlTFavT9sO0dNAU rcEiBhL77IcAfJ2clqhh1fWJMJw1TpqEBHWTEQF3h0V1ZxygWvzq11vfs300NPRkxSg== X-Gm-Gg: AY/fxX5FIxPMIvUxwhNNXOXlr4W6fKqSAtYStC3Nd1p5CEWVNJoJEKKZfpy0cmFF5I+ aLTxE5bQ/iyFtUWaGUoyOggchUErp6akL1uIcv/EedzLik5Sf3UGkwGPutvDzR4MYGN4t7Yg4/W ydYfPe4eGBOS5LdbQrW5M0amAPQVZyPrqHFbO5w3R1zGQr0a0Befuj7c3IF+ZJZ1FjQVvCTNk1Z uU0W5edACkBdskbUcfqZKbzJdwHeUgTnwhKt4U6ROiHCLWGk/9tfPWg0JTp3GJFe/WcjL40GS30 q85BANwjnKDk9ExNk9RTpycYZ/L2hoDR22eT5g8HMraSduaZa8LIC7n/IXBYBL5Jhk+de4rR5MX Pt/z32gUQuQv42IbfN5ZKZqD3hPcnEKWfJDuETb7hGpYEPbtSnEJynrBn++o5Yrz23yGX X-Received: by 2002:a05:600c:524a:b0:477:7bca:8b2b with SMTP id 5b1f17b1804b1-47a8f8cdd7amr154055945e9.15.1765874130589; Tue, 16 Dec 2025 00:35:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IGg4DsBBMTjdBs4v5Z9pExfTw83j2yc3D8FN4HEo9n85JrV8+S0/gvUDfs834nqTFADOFUU/Q== X-Received: by 2002:a05:600c:524a:b0:477:7bca:8b2b with SMTP id 5b1f17b1804b1-47a8f8cdd7amr154055775e9.15.1765874130232; Tue, 16 Dec 2025 00:35:30 -0800 (PST) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a8f8d9a06sm226130025e9.10.2025.12.16.00.35.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 00:35:29 -0800 (PST) From: Javier Martinez Canillas To: Jocelyn Falempe , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jocelyn Falempe , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v4 1/2] drm/panic: Rename draw_panic_static_* to draw_panic_screen_* In-Reply-To: <20251216082524.115980-2-jfalempe@redhat.com> References: <20251216082524.115980-1-jfalempe@redhat.com> <20251216082524.115980-2-jfalempe@redhat.com> Date: Tue, 16 Dec 2025 09:35:28 +0100 Message-ID: <87fr9alt7z.fsf@ocarina.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Jocelyn Falempe writes: Hello Jocelyn, > I called them "static" because the panic screen is drawn only once, > but this can be confused with the static meaning in C. > Also remove some unnecessary braces in draw_panic_dispatch(). > No functionnal change. > > Signed-off-by: Jocelyn Falempe > --- Makes sense. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat