mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Michael Walle <mwalle@kernel.org>
Cc: Srinivas Kandagatla <srini@kernel.org>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] nvmem: layouts: fix automatic module loading
Date: Sun, 24 Aug 2025 18:10:37 +0200	[thread overview]
Message-ID: <87frdgk8ea.fsf@bootlin.com> (raw)
In-Reply-To: <20250819112103.1084387-1-mwalle@kernel.org> (Michael Walle's message of "Tue, 19 Aug 2025 13:21:03 +0200")

Hello,

On 19/08/2025 at 13:21:03 +02, Michael Walle <mwalle@kernel.org> wrote:

> To support loading of a layout module automatically the MODALIAS
> variable in the uevent is needed. Add it.
>
> Fixes: fc29fd821d9a ("nvmem: core: Rework layouts to become regular devices")
> Cc: stable@vger.kernel.org
> Signed-off-by: Michael Walle <mwalle@kernel.org>
> ---
> I'm still not sure if the sysfs modalias file is required or not. It
> seems to work without it. I could't find any documentation about it.

I do not recall how this worked on my side, nor if it actually did with
the latest version (there's been a version where module loading was
requested in kernel code, and this was working well with an initamfs
IIRC), but that change sound reasonable.

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miquèl

  reply	other threads:[~2025-08-24 16:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-19 11:21 Michael Walle
2025-08-24 16:10 ` Miquel Raynal [this message]
2025-09-04  7:47 ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87frdgk8ea.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mwalle@kernel.org \
    --cc=srini@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®