From: Jonathan Corbet <corbet@lwn.net>
To: "Štěpán Němec" <stepnem@smrk.net>
Cc: "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: admin-guide: update to current minimum pipe size default
Date: Mon, 28 Jul 2025 13:52:31 -0600 [thread overview]
Message-ID: <87fregxfcw.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20250728193030Z.1636311400-stepnem@smrk.net>
Štěpán Němec <stepnem@smrk.net> writes:
> On Mon, 28 Jul 2025 13:07:58 -0600
> Jonathan Corbet wrote:
>
>> Štěpán Němec <stepnem@smrk.net> writes:
>>
>>> Fixes: 46c4c9d1beb7 ("pipe: increase minimum default pipe size to 2 pages")
>>> Signed-off-by: Štěpán Němec <stepnem@smrk.net>
>>> ---
>
> [...]
>
>> This seems like a reasonable change, but can I ask you to resubmit it
>> with a proper changelog, please?
>
> Do you mean a better/longer commit message?
>
> I felt that the Subject: and Fixes: says it all and didn't
> want to duplicate information (contained in its commit
> message and comments added by that change, as well as the
> very paragraph we're updating here).
>
> Would adding something like
>
> The pipe size limit used when the fs.pipe-user-pages-soft
> sysctl value is reached was increased from one to two
> pages in commit 46c4c9d1beb7; update the documentation to
> match the new reality.
>
> work?
Yes, that is what I had in mind. Patches should always explain
themselves without making people chase down Fixes tags and such.
Thanks,
jon
prev parent reply other threads:[~2025-07-28 19:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 18:30 Štěpán Němec
2025-07-28 19:07 ` Jonathan Corbet
2025-07-28 19:30 ` Štěpán Němec
2025-07-28 19:52 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fregxfcw.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=alex_y_xu@yahoo.ca \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stepnem@smrk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®