From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51BA5C4332F for ; Mon, 28 Nov 2022 01:09:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229634AbiK1BJu (ORCPT ); Sun, 27 Nov 2022 20:09:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229526AbiK1BJs (ORCPT ); Sun, 27 Nov 2022 20:09:48 -0500 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD449DE8E for ; Sun, 27 Nov 2022 17:09:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669597787; x=1701133787; h=from:to:cc:subject:references:date:message-id: mime-version:content-transfer-encoding; bh=uuTaaO7JryQZC0tYOmM4PTcCbaR1Dwdh/nRHJOJusiw=; b=Ed9RzN/S1CUNVNMIjJ4NmbbD/r9Jn+XOmLMZSkGSR1LMXVVVc1YQDuZC GsY5adQ5zmDCqCuwtdwffGGGK9vfWKgha1ZXidx1NZlEpEvLxdZfMqL49 nVtqeCVR3irOh5zUkmU+S586PWvcpYdbxBMlp4e3GsiRo6cd4L1ky5+G3 EFFNLYNDyOrKK2MVZiGbR5LRFe+tDaGbXr+vsuXMzkW2JtueZTYYl24dl kuENzO/b6REkNXlQDV4bpxW0KlhwGnyXveQH6aw4HkvqNNcexhY1EEOjp 7C4zJEeP/qrzO6llxGNVuzpG67YzY3rzI16l+EqvrUd63PZ/Pq1/bQA/f w==; X-IronPort-AV: E=McAfee;i="6500,9779,10544"; a="316550551" X-IronPort-AV: E=Sophos;i="5.96,199,1665471600"; d="scan'208";a="316550551" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Nov 2022 17:09:47 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10544"; a="731954173" X-IronPort-AV: E=Sophos;i="5.96,199,1665471600"; d="scan'208";a="731954173" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Nov 2022 17:09:13 -0800 From: "Huang, Ying" To: xialonglong Cc: , , , , , , "Wangkefeng (OS Kernel Lab)" , chenwandun , Subject: Re: =?utf-8?B?44CQQlVH44CRTlVMTA==?= pointer dereference at __lookup_swap_cgroup References: <25f28e73-5fc6-6e7f-3d41-a5970537fb8b@huawei.com> Date: Mon, 28 Nov 2022 09:08:20 +0800 Message-ID: <87fse3homz.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ascii Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, xialonglong writes: > A panic occur in the linux 5.10 we meet it only once it seems that > there is no special changes between 5.10 and upsteam about swap_cgroup. > > The test is based on QEMU with 64GB memory, one 2GB zram device as > swap area. > The test steps: > 1.swapoff -a > 2.add some memory pressure by stress-ng > 3.while (2 minutes) { > swapoff /dev/zram0 > swapon /dev/zram0 > sleep 3 > } > 4. swapon -a > > Preliminary analysis showed that the swap entry point to a swap area > which have already been swapoff, and no other obvious clues, still > trying to reproduce it. We have a patch as follows to fix a similar issue, 2799e77529c2a25492a4395db93996e3dacd762d Author: Miaohe Lin AuthorDate: Mon Jun 28 19:36:50 2021 -0700 Commit: Linus Torvalds CommitDate: Tue Jun 29 10:53:49 2021 -0700 swap: fix do_swap_page() race with swapoff When I was investigating the swap code, I found the below possible race window: CPU 1 CPU 2 ----- ----- do_swap_page if (data_race(si->flags & SWP_SYNCHRONOUS_IO) swap_readpage if (data_race(sis->flags & SWP_FS_OPS)) { swapoff .. p->swap_file = NULL; .. struct file *swap_file = sis->swap_file; struct address_space *mapping = swap_file->f_mapping;[oops!] Note that for the pages that are swapped in through swap cache, this isn't an issue. Because the page is locked, and the swap entry will be marked with SWAP_HAS_CACHE, so swapoff() can not proceed until the page has been unlocked. Fix this race by using get/put_swap_device() to guard against concurrent swapoff. Can you check whether that can fix your issue? Best Regards, Huang, Ying > Any known issue about this feature, or any advise will be appreciated. > > Here are the panic log, > > Unable to handle kernel NULL pointer dereference at virtual address > 0000000000000740 > Mem abort info: > ESR = 0x96000004 > EC = 0x25: DABT (current EL), IL = 32 bits SET = 0, FnV = 0 EA = 0, > S1PTW = 0 Data abort info: > ISV = 0, ISS = 0x00000004 > CM = 0, WnR = 0 > user pgtable: 4k pages, 48-bit VAs, pgdp=000000010ae6e000 > pgd=0000000000000000, p4d=0000000000000000 Internal error: Oops: > 96000004 [#1] SMP Hardware name: QEMU KVM Virtual Machine, BIOS 0.0.0 > 02/06/2015 > pstate: 00000005 (nzcv daif -PAN -UAO -TCO BTYPE=--) > pc : lookup_swap_cgroup_id+0x38/0x50 > lr : mem_cgroup_charge+0x9c/0x424 > sp : ffff800102f63bc0 > x29: ffff800102f63bc0 x28: ffff0000d0d64d00 > x27: 0000000000000000 x26: 0000000000000007 > x25: ffff0000018c86a8 x24: ffff0000018c8640 > x23: 0000000000000cc0 x22: 0000000000000001 > x21: 0000000000000001 x20: ffff800102f63d28 > x19: fffffe000373cb40 x18: 0000000000000000 > x17: 0000000000000000 x16: ffff8001004715a4 > x15: 00000000ffffffff x14: 0000000000003000 > x13: 00000000ffffffff x12: 0000000000000040 > x11: ffff0000c0403478 x10: ffff0000c040347a > x9 : ffff8001003e957c x8 : 000000000009dddd > x7 : 0000000000000600 x6 : 00000000000000e8 > x5 : 0000020000200000 x4 : ffff000000000000 > x3 : ffff800101f4c030 x2 : 0000000000000000 > x1 : 00000000000001e4 x0 : 0000000000000000 > > Call trace: > lookup_swap_cgroup_id+0x38/0x50 > do_swap_page+0xa64/0xc04 > handle_pte_fault+0x1c8/0x214 > __handle_mm_fault+0x1b0/0x380 > handle_mm_fault+0xf4/0x284 > do_page_fault+0x188/0x474 > do_translation_fault+0xb8/0xe4 > do_mem_abort+0x48/0xb0 > el0_da+0x44/0x80 > el0_sync_handler+0x88/0xb4 > el0_sync+0x160/0x180 > > :       mov   x9, x30 > :     nop > :     > lsr   x2, x0, #58 SWP_TYPE_SHIFT == 58  x2 = > swp_type > :     > adrp  x1, 0xffff800101f4c000 > > :    > add   x3, x1, #0x30     > x3 == swap_cgroup_ctrl > :    ubfx  x6, x0, #11, #47 > :    add   x2, x2, x2, lsl #1 > :    ubfiz  x1, x0, #1, #11 > :    > mov   x5, > #0x200000          > // #2097152 > :    > mov   x4, > #0xffff000000000000     // > #-281474976710656 > :    movk  x5, #0x200, lsl #32 > :    hint  #0x19 > :    > ldr   x0, [x3,x2,lsl #3] x3=ffff800101f4c030, x0 = 0 > :    hint  #0x1d > :    > ldr   x0, [x0,x6,lsl #3] x0 = 0 + 0xe8 * 8 == 0x740 > :    add   x0, x0, x5 > :    lsr   x0, x0, #6 > :    add   x0, x1, x0, lsl #12 > :    ldrh  w0, [x0,x4] > :    ret