From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D04E0C38A2D for ; Tue, 25 Oct 2022 12:50:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232488AbiJYMui (ORCPT ); Tue, 25 Oct 2022 08:50:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232324AbiJYMt7 (ORCPT ); Tue, 25 Oct 2022 08:49:59 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 477EB19899A for ; Tue, 25 Oct 2022 05:48:12 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 67FCE22042; Tue, 25 Oct 2022 12:48:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1666702083; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tf6lCTsPLXeNhiHXssNpP5ZAcfqyeQr9LAgewN2IdOc=; b=Emk7EU8r+ZpKKxNjD38r3SHM5QjFKqDpuMO30D/YJfG7S4ry3BDGU5o/i3UgkL41vJCMoB 7fZx50LKH0qWYFF1iN2N/RqzQj7s7jE1UFzhX9C7CQfpv5QmNnRiQVB/sfYUv5DXK9zZD7 H/BYkgutITVqz2eW+csxCDSsPEekb0Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1666702083; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tf6lCTsPLXeNhiHXssNpP5ZAcfqyeQr9LAgewN2IdOc=; b=/qoI9YuABKQTvZDMU0BmeXDvQi5ny3aW3bD6o0llH2KCcesvcq7iYspOGDM0R78i38vZqZ EdzSglkd4lfI8VCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 445CF13A64; Tue, 25 Oct 2022 12:48:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 5sywDwPbV2M0JgAAMHmgww (envelope-from ); Tue, 25 Oct 2022 12:48:03 +0000 Date: Tue, 25 Oct 2022 14:48:02 +0200 Message-ID: <87fsfcqdbx.wl-tiwai@suse.de> From: Takashi Iwai To: "Jason A. Donenfeld" Cc: linux-kernel@vger.kernel.org, Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org Subject: Re: [PATCH v2] ALSA: rme9652: use explicitly signed char In-Reply-To: References: <202210250456.vKv5zoLb-lkp@intel.com> <20221025000313.546261-1-Jason@zx2c4.com> <87bkq0s9rw.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Oct 2022 14:08:29 +0200, Jason A. Donenfeld wrote: > > On Tue, Oct 25, 2022 at 08:21:55AM +0200, Takashi Iwai wrote: > > On Tue, 25 Oct 2022 02:03:13 +0200, > > Jason A. Donenfeld wrote: > > > > > > With char becoming unsigned by default, and with `char` alone being > > > ambiguous and based on architecture, signed chars need to be marked > > > explicitly as such. This fixes warnings like: > > > > > > sound/pci/rme9652/hdsp.c:3953 hdsp_channel_buffer_location() warn: 'hdsp->channel_map[channel]' is unsigned > > > sound/pci/rme9652/hdsp.c:4153 snd_hdsp_channel_info() warn: impossible condition '(hdsp->channel_map[channel] < 0) => (0-255 < 0)' > > > sound/pci/rme9652/rme9652.c:1833 rme9652_channel_buffer_location() warn: 'rme9652->channel_map[channel]' is unsigned > > > > > > Cc: Jaroslav Kysela > > > Cc: Takashi Iwai > > > Cc: alsa-devel@alsa-project.org > > > Signed-off-by: Jason A. Donenfeld > > > > Applied now. Thanks! > > Thanks. For this and the other patch, applied for 6.1 or 6.2? I applied for 6.2. Was it an action that has to be fixed for 6.1? If so, I still can shuffle. thanks, Takashi