From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B16B3C33C9E for ; Wed, 15 Jan 2020 01:17:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8E4F7214AF for ; Wed, 15 Jan 2020 01:17:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728904AbgAOBRD (ORCPT ); Tue, 14 Jan 2020 20:17:03 -0500 Received: from relmlor2.renesas.com ([210.160.252.172]:29789 "EHLO relmlie6.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728795AbgAOBRD (ORCPT ); Tue, 14 Jan 2020 20:17:03 -0500 Date: 15 Jan 2020 10:17:00 +0900 X-IronPort-AV: E=Sophos;i="5.70,320,1574089200"; d="scan'208";a="36471841" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie6.idc.renesas.com with ESMTP; 15 Jan 2020 10:17:00 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id C6FE74116F0B; Wed, 15 Jan 2020 10:17:00 +0900 (JST) Message-ID: <87ftgh8qnn.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto Subject: [PATCH] regulator: core: fixup regulator_is_equal() helper User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 To: Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, Marek Vasut , Fabio Estevam , Igor Opaniuk , Marcel Ziswiler , Oleksandr Suvorov MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kuninori Morimoto commit b059b7e0ec320 ("regulator: core: Add regulator_is_equal() helper") added regulator_is_equal() helper. But it has unneeded ";" if CONFIG_REGULATOR was not defined. Thus, we will have this error linux/include/linux/regulator/consumer.h:600:1: error: expected \ identifier or '(' before '{' token { ^ linux/include/linux/regulator/consumer.h:599:1: warning: \ 'regulator_is_equal' declared 'static' but never defined \ [-Wunused-function] regulator_is_equal(struct regulator *reg1, struct regulator *reg2); ^~~~~~~~~~~~~~~~~~ This patch fixup it. Cc: Marek Vasut Cc: Fabio Estevam Cc: Igor Opaniuk Cc: Liam Girdwood Cc: Marcel Ziswiler Cc: Mark Brown Cc: Oleksandr Suvorov Signed-off-by: Kuninori Morimoto --- include/linux/regulator/consumer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/regulator/consumer.h b/include/linux/regulator/consumer.h index 2c89d88..6a92fd3 100644 --- a/include/linux/regulator/consumer.h +++ b/include/linux/regulator/consumer.h @@ -596,7 +596,7 @@ regulator_bulk_set_supply_names(struct regulator_bulk_data *consumers, } static inline bool -regulator_is_equal(struct regulator *reg1, struct regulator *reg2); +regulator_is_equal(struct regulator *reg1, struct regulator *reg2) { return false; } -- 2.7.4