From: Michael Ellerman <mpe@ellerman.id.au>
To: Christophe Leroy <christophe.leroy@c-s.fr>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/8xx: hide itlbie and dtlbie symbols
Date: Thu, 13 Dec 2018 00:05:23 +1100 [thread overview]
Message-ID: <87ftv2x5d8.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <8a48b395c3468f8020ea56af679530854b090e4c.1543404405.git.christophe.leroy@c-s.fr>
Christophe Leroy <christophe.leroy@c-s.fr> writes:
> When disassembling InstructionTLBError we get the following messy code:
>
> c000138c: 7d 84 63 78 mr r4,r12
> c0001390: 75 25 58 00 andis. r5,r9,22528
> c0001394: 75 2a 40 00 andis. r10,r9,16384
> c0001398: 41 a2 00 08 beq c00013a0 <itlbie>
> c000139c: 7c 00 22 64 tlbie r4,r0
>
> c00013a0 <itlbie>:
> c00013a0: 39 40 04 01 li r10,1025
> c00013a4: 91 4b 00 b0 stw r10,176(r11)
> c00013a8: 39 40 10 32 li r10,4146
> c00013ac: 48 00 cc 59 bl c000e004 <transfer_to_handler>
>
> For a cleaner code dump, this patch replaces itlbie and dtlbie
> symbols by numeric symbols.
>
> c000138c: 7d 84 63 78 mr r4,r12
> c0001390: 75 25 58 00 andis. r5,r9,22528
> c0001394: 75 2a 40 00 andis. r10,r9,16384
> c0001398: 41 a2 00 08 beq c00013a0 <InstructionTLBError+0xa0>
> c000139c: 7c 00 22 64 tlbie r4,r0
> c00013a0: 39 40 04 01 li r10,1025
> c00013a4: 91 4b 00 b0 stw r10,176(r11)
> c00013a8: 39 40 10 32 li r10,4146
> c00013ac: 48 00 cc 59 bl c000e004 <transfer_to_handler>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> ---
> arch/powerpc/kernel/head_8xx.S | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/arch/powerpc/kernel/head_8xx.S b/arch/powerpc/kernel/head_8xx.S
> index 3b67b9533c82..8c848acfe249 100644
> --- a/arch/powerpc/kernel/head_8xx.S
> +++ b/arch/powerpc/kernel/head_8xx.S
> @@ -552,11 +552,10 @@ InstructionTLBError:
> mr r4,r12
> andis. r5,r9,DSISR_SRR1_MATCH_32S@h /* Filter relevant SRR1 bits */
> andis. r10,r9,SRR1_ISI_NOPT@h
> - beq+ 1f
> + beq+ 1301f
> tlbie r4
> -itlbie:
> /* 0x400 is InstructionAccess exception, needed by bad_page_fault() */
> -1: EXC_XFER_LITE(0x400, handle_page_fault)
> +1301: EXC_XFER_LITE(0x400, handle_page_fault)
You could use a local symbol, something like:
beq+ 1f
tlbie r4
.Litlbie:
/* 0x400 is InstructionAccess exception, needed by bad_page_fault() */
1: EXC_XFER_LITE(0x400, handle_page_fault)
cheers
next prev parent reply other threads:[~2018-12-12 13:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 11:27 Christophe Leroy
2018-12-12 13:05 ` Michael Ellerman [this message]
2018-12-13 8:09 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftv2x5d8.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®