From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22B7EC04EB8 for ; Thu, 6 Dec 2018 03:35:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E386D2146D for ; Thu, 6 Dec 2018 03:35:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E386D2146D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729043AbeLFDfF (ORCPT ); Wed, 5 Dec 2018 22:35:05 -0500 Received: from ozlabs.org ([203.11.71.1]:43505 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727940AbeLFDfF (ORCPT ); Wed, 5 Dec 2018 22:35:05 -0500 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 439Lnv6lPZz9s1c; Thu, 6 Dec 2018 14:34:59 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au From: Michael Ellerman To: Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Benjamin Herrenschmidt , Paul Mackerras , Greg Kroah-Hartman , Jiri Slaby , "David S. Miller" , linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH] tty: Use of_node_name_{eq,prefix} for node name comparisons In-Reply-To: <20181205195050.4759-27-robh@kernel.org> References: <20181205195050.4759-27-robh@kernel.org> Date: Thu, 06 Dec 2018 14:34:56 +1100 Message-ID: <87ftvbl44f.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rob Herring writes: > Convert string compares of DT node names to use of_node_name_eq helper > instead. This removes direct access to the node name pointer. > > For hvc, the code can also be simplified by using of_stdout pointer > instead of searching again for the stdout node. > > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: "David S. Miller" > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-serial@vger.kernel.org > Cc: sparclinux@vger.kernel.org > Signed-off-by: Rob Herring > --- > drivers/tty/hvc/hvc_opal.c | 2 +- > drivers/tty/hvc/hvc_vio.c | 11 +---------- > drivers/tty/serial/pmac_zilog.c | 4 ++-- LGTM. Acked-by: Michael Ellerman (powerpc) cheers