mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Chen Guanqiao <chen.chenchacha@foxmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] fs: fat: add ioctl to modify fat filesystem partion volume label
Date: Fri, 22 Dec 2017 04:25:20 +0900	[thread overview]
Message-ID: <87fu83lw7z.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <cover.1513860623.git.chen.chenchacha@foxmail.com> (Chen Guanqiao's message of "Thu, 21 Dec 2017 20:56:39 +0800")

Chen Guanqiao <chen.chenchacha@foxmail.com> writes:

> The FAT filesystem partition volume label can be read with
> FAT_IOCTL_GET_VOLUME_LABEL and written with FAT_IOCTL_SET_VOLUME_LABEL.
>
> v2:
> 1. add filesystem version check.
> 2. add diretory permissions check.
> 3. add volume label string check.
> 4. fixed part of return value.
> 5. fixed some indent issue.
> 6. remove sync_dirty_buffer().

As I said in previous email, those vol_label should be matching with
volume label in root directory, right? So I think handling only boot
sector's vol_label would not work as expected.

Does this really works as expected?

E.g. suspected test case is,

1) write label on windows
2) modify label on linux
3) read modified label on windows

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

      parent reply	other threads:[~2017-12-21 19:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-21 12:56 Chen Guanqiao
2017-12-21 12:56 ` [PATCH 1/2] fs: fat: add fat filesystem partition volume label in local structure Chen Guanqiao
2017-12-21 12:56 ` [PATCH 2/2] fs: fat: add ioctl method in fat filesystem driver Chen Guanqiao
2017-12-21 19:25 ` OGAWA Hirofumi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fu83lw7z.fsf@mail.parknet.co.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=chen.chenchacha@foxmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome