From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757828AbdEVJMx (ORCPT ); Mon, 22 May 2017 05:12:53 -0400 Received: from ozlabs.org ([103.22.144.67]:43565 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757580AbdEVJMv (ORCPT ); Mon, 22 May 2017 05:12:51 -0400 From: Michael Ellerman To: Pavel Machek Cc: Andrew Morton , mark.rutland@arm.com, devicetree@vger.kernel.org, trivial@kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, paulus@samba.org, Andrew Morton , jwboyer@linux.vnet.ibm.com, sr@denx.de, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap In-Reply-To: <20170519111837.GB3940@amd> References: <20170402100535.GA18340@amd> <20170517120613.GA583@amd> <20170517143717.ad818a2282378fc7a38af1ff@linux-foundation.org> <20170518094813.GA12038@amd> <87efvl75ts.fsf@concordia.ellerman.id.au> <87zie95fiq.fsf@concordia.ellerman.id.au> <20170519111837.GB3940@amd> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Mon, 22 May 2017 19:12:48 +1000 Message-ID: <87fufxs19r.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pavel Machek writes: > Hi! > >> >>> > > Signed-off-by: Pavel Machek >> >>> > >> >>> > Ping? Two partitions at same place are bad news... >> >>> >> >>> Please expand on "bad news"? What are the runtime effects of this >> >>> change? Decisions about which kernel(s) to patch depend on this info. >> >> >> >> Well... two partitions at same place. If you use one, you will corrupt >> >> information on the other one. >> >> >> >> OTOH this moves partition around (so that they don't overlap) so it is >> >> probably not stable candidate. >> >> >> >> I guess this is not huge issue; people using these boards probably >> >> have custom dts changes, anyway... >> > >> > Or no one's even using it anymore. >> > >> > I can take this via powerpc, I won't mark it for stable etc. >> >> It became: >> >> Author: Pavel Machek >> >> powerpc/sequoia: Fix NAND partitions not to overlap >> >> Currently the DTS defines two partitions at the same addresses, if you >> use one, you will corrupt information on the other one. Fix it by >> shifting the second partition. >> >> Signed-off-by: Pavel Machek >> [mpe: Reconstruct change log from email thread] >> Signed-off-by: Michael Ellerman >> >> >> Minor nit, your From: address doesn't match your Signed-off-by: address, >> which trips my "check patch is signed-off-by author" script. I can >> just ignore it, but I think it's preferable if they match. > > Sorry about that (I have automatic scripts changing From:). It is > still me, but I guess denx should get the credit here, so you can use. > > Signed-off-by: Pavel Machek Sure, done. cheers