From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754971AbdBVVfB (ORCPT ); Wed, 22 Feb 2017 16:35:01 -0500 Received: from ozlabs.org ([103.22.144.67]:35029 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932834AbdBVVed (ORCPT ); Wed, 22 Feb 2017 16:34:33 -0500 From: Michael Ellerman To: Frederic Weisbecker , LKML Cc: Frederic Weisbecker , Abdul Haleem , "Oliver O'Halloran" , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] powerpc: Remove leftover cputime_to_nsecs call causing build error In-Reply-To: <1487690321-21553-1-git-send-email-fweisbec@gmail.com> References: <1487690321-21553-1-git-send-email-fweisbec@gmail.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Thu, 23 Feb 2017 08:34:15 +1100 Message-ID: <87fuj5zz8o.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Frederic Weisbecker writes: > This type conversion is a leftover that got ignored during the kcpustat > conversion to nanosecs, resulting in build breakage with config having > CONFIG_NO_HZ_FULL=y. > > arch/powerpc/kernel/time.c: In function 'running_clock': > arch/powerpc/kernel/time.c:712:2: error: implicit declaration of function 'cputime_to_nsecs' [-Werror=implicit-function-declaration] > return local_clock() - cputime_to_nsecs(kcpustat_this_cpu->cpustat[CPUTIME_STEAL]); > > All we need is to remove it. > > Reported-by: Abdul Haleem > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Oliver O'Halloran > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Frederic Weisbecker LGTM. Acked-by: Michael Ellerman Are you going to send this to Linus, or should I? cheers > diff --git a/arch/powerpc/kernel/time.c b/arch/powerpc/kernel/time.c > index 14e4855..bc84a8d 100644 > --- a/arch/powerpc/kernel/time.c > +++ b/arch/powerpc/kernel/time.c > @@ -709,7 +709,7 @@ unsigned long long running_clock(void) > * time and on a host which doesn't do any virtualisation TB *should* equal > * VTB so it makes no difference anyway. > */ > - return local_clock() - cputime_to_nsecs(kcpustat_this_cpu->cpustat[CPUTIME_STEAL]); > + return local_clock() - kcpustat_this_cpu->cpustat[CPUTIME_STEAL]; > } > #endif > > -- > 2.7.4