From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751686AbdBOU4U (ORCPT ); Wed, 15 Feb 2017 15:56:20 -0500 Received: from anholt.net ([50.246.234.109]:44970 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751356AbdBOU4T (ORCPT ); Wed, 15 Feb 2017 15:56:19 -0500 From: Eric Anholt To: Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/vc4: Drop debug print at boot with DPI enabled. In-Reply-To: <20170209171115.njqhfot7so4vb7ed@phenom.ffwll.local> References: <20170208204701.29013-1-eric@anholt.net> <20170209171115.njqhfot7so4vb7ed@phenom.ffwll.local> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Wed, 15 Feb 2017 12:56:16 -0800 Message-ID: <87fujfjhqn.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Daniel Vetter writes: > On Wed, Feb 08, 2017 at 12:47:01PM -0800, Eric Anholt wrote: >> Unlike the other encoders in the driver, I've also dropped the debug >> dump function. There's only really one register to this device, and >> we have the debugfs reg entry still. >>=20 >> Signed-off-by: Eric Anholt > > Yeah, dmesg spew by default isn't cool. Btw if you ever want to have fancy > debug printers, there's drm_printer, which allows you to spam both dmesg > and debugfs with the same code. Rob did that, I recently converted drm_mm, > it's pretty cool. > > Acked-by: Daniel Vetter Merged to -next, thanks. The drm printer stuff looks really promising! I'm also interested, though, in the debugfs_regset32 stuff that lets you just name your regs in a struct and pass it and your regs base address to the helper for creating the debugfs entry. I bet we can mash those two ideas together into something really nice. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlikwHAACgkQtdYpNtH8 nug2ShAAmRBYaDj4FI4L+jRiSrqsaZoW6q6wjLeYyz5yqYPij9jN+yzswMbXTDba taicejtUTCOQQE8WRsFXIk/eLf96wc+lLlNS8P0jyVpkSBt3tgl9XwGnFJVYVqVo k+cPEkblUkb3df+6PcTPtpkmliBVlO0uAZjEMF1TgYnWcMrdbi2D7vs//dcFaxtM 7pIr+X2VcNn8wIG2dlU5Zsawv0qhdZ2GJ8HuXEMHndmrBT2F3Wn7Y2GU26Ybyxay yI/2BcgW5/7jPgxlzcYpAxZEU0/R9rUOhK4e6OcL6EsVXOGxZYUR7nVdauJoGrsp +AjJ4CqUpLOOW5gsklOFjC6B1v/s0EqHygxHABlvwlRasMr2FqzNeAkwIPNzMAEN NHxWhig3nmYpT/sYz+ktbbLzlCVRWmK+SUvDyEhg7lnVWrpNHQPtTLnDp2ykq1IF O8Oq1S7UKlTpQD60iYWa/4x6YhNl67ypcorA0aV/PJUX2SdPVDpcm0KInjOUl+17 23sHIIBf8Wjh4mjcBDq95NkfxTwpIbsNgUi/iYbajaTjwoM+MeiUHEw/S2reJ8BS vo5jfTxrcnJ6HMkDEtN4ixmNU6zgp+osyjv/hxOCuQlPKHC1JwLgwKCvcsREkvJM OkEQ0DiHW9ID3v8/S8MAnMkbwXx+dQMvSuJPTzTC1oiMPX6zEJ0= =ikjQ -----END PGP SIGNATURE----- --=-=-=--