From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753321AbdBNNJY (ORCPT ); Tue, 14 Feb 2017 08:09:24 -0500 Received: from mga04.intel.com ([192.55.52.120]:50055 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752594AbdBNNIM (ORCPT ); Tue, 14 Feb 2017 08:08:12 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,161,1484035200"; d="scan'208";a="820756533" From: Alexander Shishkin To: Ingo Molnar Cc: Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org, vince@deater.net, eranian@google.com, Arnaldo Carvalho de Melo , Will Deacon , Mark Rutland , Mathieu Poirier Subject: Re: [PATCH 3/3] perf: Allow kernel filters on cpu events In-Reply-To: <20170210080756.GA1977@gmail.com> References: <20170126094057.13805-1-alexander.shishkin@linux.intel.com> <20170126094057.13805-4-alexander.shishkin@linux.intel.com> <20170210080756.GA1977@gmail.com> User-Agent: Notmuch/0.23.5 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 14 Feb 2017 14:59:37 +0200 Message-ID: <87fujhkjwm.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ingo Molnar writes: > * Alexander Shishkin wrote: > >> While supporting file-based address filters for cpu events requires some >> extra context switch handling, kernel address filters are easy, since the >> kernel mapping is preserved across address spaces. It is also useful as >> it permits tracing scheduling paths of the kernel. >> >> This patch allows setting up kernel filters for cpu events. >> >> Signed-off-by: Alexander Shishkin >> Cc: Mathieu Poirier >> --- >> include/linux/perf_event.h | 2 ++ >> kernel/events/core.c | 42 ++++++++++++++++++++++++++++-------------- >> 2 files changed, 30 insertions(+), 14 deletions(-) >> >> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h >> index fcb37c81ca..f4ea0600b2 100644 >> --- a/include/linux/perf_event.h >> +++ b/include/linux/perf_event.h >> @@ -486,6 +486,7 @@ struct perf_addr_filter { >> * @list: list of filters for this event >> * @lock: spinlock that serializes accesses to the @list and event's >> * (and its children's) filter generations. >> + * @nr_file_filters: number of file-based filters > > I've applied the patch, but please for heaven's sake, when you add such a long, > long argument name, at minimum re-tabulate the documentation section to look good > again ... Will do. >>From 8b993fa566acb0cd333ce5e433f1e6858b181f58 Mon Sep 17 00:00:00 2001 From: Alexander Shishkin Date: Tue, 14 Feb 2017 14:49:41 +0200 Subject: [PATCH] perf: Fix alignment in a kerneldoc comment Commit 6ce77bfd6c ("perf/core: Allow kernel filters on CPU events") added "nr_file_filters" to the filters structure and its kerneldoc description, which now requires that other fields' descriptions be padded to the next tabstop to not look ugly. Signed-off-by: Alexander Shishkin --- include/linux/perf_event.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index 258ebdb533..8f347b84cf 100644 --- a/include/linux/perf_event.h +++ b/include/linux/perf_event.h @@ -503,9 +503,9 @@ struct perf_addr_filter { /** * struct perf_addr_filters_head - container for address range filters - * @list: list of filters for this event - * @lock: spinlock that serializes accesses to the @list and event's - * (and its children's) filter generations. + * @list: list of filters for this event + * @lock: spinlock that serializes accesses to the @list and + * event's (and its children's) filter generations. * @nr_file_filters: number of file-based filters * * A child event will use parent's @list (and therefore @lock), so they are -- 2.11.0