From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752721AbcJZFc4 (ORCPT ); Wed, 26 Oct 2016 01:32:56 -0400 Received: from ozlabs.org ([103.22.144.67]:58213 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752359AbcJZFcy (ORCPT ); Wed, 26 Oct 2016 01:32:54 -0400 From: Michael Ellerman To: Borislav Petkov Cc: akpm@osdl.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, peterz@infradead.org, jgross@suse.com, mgorman@techsingularity.net, richard@nod.at, len.brown@intel.com, boris.ostrovsky@oracle.com, tim.c.chen@linux.intel.com, ak@linux.intel.com, jolsa@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] kernel/smp: Make the SMP boot message common on all arches In-Reply-To: <20161014115446.gowu4r3aereixwz7@pd.tnic> References: <1476348920-15066-1-git-send-email-mpe@ellerman.id.au> <20161014115446.gowu4r3aereixwz7@pd.tnic> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Wed, 26 Oct 2016 16:32:47 +1100 Message-ID: <87funjy8sg.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Borislav Petkov writes: > On Thu, Oct 13, 2016 at 07:55:19PM +1100, Michael Ellerman wrote: >> @@ -564,8 +560,11 @@ void __init smp_init(void) >> cpu_up(cpu); >> } >> >> + num_nodes = num_online_nodes(); >> + pr_info("smp: Brought up %d node%s, %d CPUs\n", >> + num_nodes, (num_nodes > 1 ? "s" : ""), num_online_cpus()); > > Please define pr_fmt for this file so that pr_info adds the prefix > automatically. I guess > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > at the top, before all the include directives should suffice. Sure thing. > Other than that, for both patches: > > Reviewed-by: Borislav Petkov Thanks, v2 coming soon. cheers