From: Eric Anholt <eric@anholt.net>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Stephen Warren <swarren@wwwdotorg.org>,
Lee Jones <lee@kernel.org>,
devicetree@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>
Subject: Re: [PATCH] irqchip: bcm2836: Use a CPU notifier enable IPIs.
Date: Mon, 03 Aug 2015 16:23:09 -0700 [thread overview]
Message-ID: <87fv40lzxe.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <alpine.DEB.2.11.1508021221370.3825@nanos>
[-- Attachment #1: Type: text/plain, Size: 711 bytes --]
Thomas Gleixner <tglx@linutronix.de> writes:
> On Mon, 27 Jul 2015, Eric Anholt wrote:
>> +/* Unmasks the IPI on the CPU wen it's first brought online. */
>
> when
>
>> +static int bcm2836_arm_irqchip_cpu_notify(struct notifier_block *nfb,
>> + unsigned long action, void *hcpu)
>> +{
>> + unsigned int cpu = (unsigned long)hcpu;
>> + unsigned int int_reg = LOCAL_MAILBOX_INT_CONTROL0;
>> + unsigned int mailbox = 0;
>> +
>> + if (action == CPU_STARTING || action == CPU_STARTING_FROZEN)
>> + bcm2836_arm_irqchip_unmask_per_cpu_irq(int_reg, mailbox, cpu);
>
> Shouldn't you mask the irq on CPU_DYING?
I was just following what other drivers were doing. Is CPU_DYING the
only thing that needs masking?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2015-08-03 23:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 1:35 Raspberry Pi 2 interrupt controller support (v2) Second round Eric Anholt
2015-07-14 1:35 ` [PATCH v2 1/4] irqchip: bcm2835: Refactor handle_IRQ() calls out of MAKE_HWIRQ Eric Anholt
2015-07-14 1:35 ` [PATCH v2 2/4] irqchip: bcm2835: If a parent interrupt is registered, chain from it Eric Anholt
2015-07-22 2:08 ` Stephen Warren
2015-07-22 18:17 ` Eric Anholt
2015-07-24 4:13 ` Stephen Warren
2015-07-14 1:35 ` [PATCH v2 3/4] irqchip: Add documentation for the bcm2836 interrupt controller Eric Anholt
2015-07-14 1:35 ` [PATCH v2 4/4] irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2 Eric Anholt
2015-07-22 2:09 ` Stephen Warren
2015-07-22 18:02 ` Eric Anholt
2015-07-26 9:52 ` Thomas Gleixner
2015-07-27 18:42 ` [PATCH] irq-bcm2836: Move SMP boot to the irqchip code Eric Anholt
2015-07-27 18:46 ` Florian Fainelli
2015-07-27 20:09 ` [PATCH] irqchip: bcm2836: Use a CPU notifier enable IPIs Eric Anholt
2015-08-02 10:22 ` Thomas Gleixner
2015-08-03 23:23 ` Eric Anholt [this message]
2015-08-04 7:14 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fv40lzxe.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=swarren@wwwdotorg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome