From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>,
Chunyan Zhang <zhang.chunyan@linaro.org>
Cc: rostedt@goodmis.org, mingo@redhat.com,
mathieu.poirier@linaro.org, serge.broslavsky@linaro.org,
broonie@kernel.org, zhang.lyra@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v3 1/4] STM trace event: Adding generic buffer interface driver
Date: Wed, 08 Jul 2015 16:09:18 +0300 [thread overview]
Message-ID: <87fv4yn6dd.fsf@ashishki-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20150708121029.GE12596@twins.programming.kicks-ass.net>
Peter Zijlstra <peterz@infradead.org> writes:
> On Tue, Jul 07, 2015 at 06:10:40PM +0800, Chunyan Zhang wrote:
>> +config STM_TRACE_EVENT
>> + tristate "Redirect/copy the output from kernel trace event to STM engine"
>
> How does tristate make sense here? You're using it unconditionally for
> in-kernel tracepoints. This must be bool, which in turn makes the whole
> STM thing bool afaiu.
That would make the whole STM thing a bool. I'd rather we used stm
output *conditionally* by somehow plugging into tracepoint output, say
with a jump label or something. Haven't had time to think about it yet.
Regards,
--
Alex
next prev parent reply other threads:[~2015-07-08 13:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 10:10 [RFC PATCH v3 0/4] Integration of trace events with System Trace IP blocks Chunyan Zhang
2015-07-07 10:10 ` [RFC PATCH v3 1/4] STM trace event: Adding generic buffer interface driver Chunyan Zhang
2015-07-08 10:23 ` Alexander Shishkin
2015-07-08 14:15 ` Mathieu Poirier
2015-07-08 12:10 ` Peter Zijlstra
2015-07-08 13:09 ` Alexander Shishkin [this message]
2015-07-07 10:10 ` [RFC PATCH v3 2/4] trace: Add an entry for printing trace log to STM Chunyan Zhang
2015-07-07 15:58 ` Steven Rostedt
2015-07-08 8:06 ` Chunyan Zhang
2015-07-07 10:10 ` [RFC PATCH v3 3/4] trace: Introduce trace log output function for STM Chunyan Zhang
2015-07-17 20:48 ` Steven Rostedt
2015-07-07 10:10 ` [RFC PATCH v3 4/4] trace: Trace log handler for logging into STM blocks Chunyan Zhang
2015-07-08 12:31 ` Peter Zijlstra
2015-07-08 13:06 ` Chunyan Zhang
2015-07-08 13:22 ` Ingo Molnar
2015-07-08 13:19 ` Steven Rostedt
2015-07-10 9:01 ` Chunyan Zhang
2015-07-17 5:59 ` Chunyan Zhang
2015-07-17 21:07 ` Steven Rostedt
2015-07-07 11:12 ` [RFC PATCH v3 0/4] Integration of trace events with System Trace IP blocks Alexander Shishkin
2015-07-08 7:42 ` Chunyan Zhang
2015-07-08 10:11 ` Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fv4yn6dd.fsf@ashishki-desk.ger.corp.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=serge.broslavsky@linaro.org \
--cc=zhang.chunyan@linaro.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®