From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758517Ab3KZWGX (ORCPT ); Tue, 26 Nov 2013 17:06:23 -0500 Received: from void.printf.net ([89.145.121.20]:49359 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758487Ab3KZWGS (ORCPT ); Tue, 26 Nov 2013 17:06:18 -0500 From: Chris Ball To: "Ray Jui" Cc: "Seungwon Jeon" , linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org Subject: Re: [PATCH v2] mmc: fix host release issue after discard operation References: <1382810624-17659-1-git-send-email-rjui@broadcom.com> Date: Tue, 26 Nov 2013 17:06:06 -0500 In-Reply-To: <1382810624-17659-1-git-send-email-rjui@broadcom.com> (Ray Jui's message of "Sat, 26 Oct 2013 11:03:44 -0700") Message-ID: <87fvqig6nl.fsf@octavius.laptop.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ray, On Sat, Oct 26 2013, Ray Jui wrote: > Under function mmc_blk_issue_rq, after an MMC discard operation, > the MMC request data structure may be freed in memory. Later in > the same function, the check of req->cmd_flags & MMC_REQ_SPECIAL_MASK > is dangerous and invalid. It causes the MMC host not to be released > when it should > > This patch fixes the issue by marking the special request down before > the discard/flush operation > > Reported by: Harold (SoonYeal) Yang > Signed-off-by: Ray Jui > Reviewed-by: Seungwon Jeon Thanks, pushed to mmc-next for 3.14 and -stable. - Chris. -- Chris Ball