mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: David Ahern <dsahern@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung.kim@lge.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Jiri Olsa <jolsa@redhat.com>
Subject: Re: [RFC/PATCH 3/3] perf script: Print mmap[2] events also
Date: Mon, 18 Nov 2013 14:18:37 +0900	[thread overview]
Message-ID: <87fvquuw2a.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <52899BFF.5080007@gmail.com> (David Ahern's message of "Sun, 17 Nov 2013 21:47:59 -0700")

Hi David,

On Sun, 17 Nov 2013 21:47:59 -0700, David Ahern wrote:
> On 11/17/13, 8:00 PM, Namhyung Kim wrote:
>> If --show-mmap option is given, also print internal MMAP and MMAP2
>> events.  It would be helpful for debugging.
>>
>> Suggested-by: Frederic Weisbecker <fweisbec@gmail.com>
>> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
>
> Outside of the free following a strdup, the 3 patches looked good to
> me. Procrastination worked in my favor. Once these go in I'll do the
> move to perf-dump.
>
> For all 3:
> Reviewed-by: David Ahern <dsahern@gmail.com>

Thank you for quick review!

I'll fix the bug you mentioned and resend.

Thanks,
Namhyung

      reply	other threads:[~2013-11-18  5:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-18  3:00 [PATCH 1/3] perf script: Move evname print code to process_event() Namhyung Kim
2013-11-18  3:00 ` [RFC/PATCH 2/3] perf script: Print comm, fork and exit events also Namhyung Kim
2013-11-18  4:44   ` David Ahern
2013-11-18  3:00 ` [RFC/PATCH 3/3] perf script: Print mmap[2] " Namhyung Kim
2013-11-18  4:47   ` David Ahern
2013-11-18  5:18     ` Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fvquuw2a.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=dsahern@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®