From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795009633; b=DvGJ9lzGA5uImmfHASo5DivTV+ScR8Lk4N7Ie91tGxttNBcDefyFhXDkOIe/kO7uJ05s Wazi+z4L10WltxRstapEDmXC+X7LcZjvy8tqgBvQ7Y0lodTmJDOQFw95yHgXl/puy/LQi sCKjbpFS47vhnHDrRvNYX0jXI4G+0XME8lRLAv+rsCN49Hr3nvq196U9g4apVvTLjxlXz AN5GR5GDhvEZFLsz/dXlSs6OaWzsNm/nqGptByFWcA7/LapijZfvJtGS8YN5ZAm/dNP9g X+IB2fwtwX+wdBA4lSpbr8jcLGUSAAiTJyGIMMdOLfWZA2fJNyoqZ8+2q06pq1LmpCQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795009633; h=DMARC-Filter:Received:DKIM-Signature:DKIM-Signature:DKIM-Signature: DKIM-Signature:Received:Received:Date:Message-ID:From:To:Cc:Subject: In-Reply-To:References:User-Agent:MIME-Version:Content-Type: X-Spamd-Result:X-Rspamd-Server:X-Rspamd-Action:X-Spam-Flag: X-Spam-Score:X-Spam-Level:X-Rspamd-Queue-Id; bh=P29+0WSfDjivL0QnkfaQfvp/outg1KtB0aHDGFukhnc=; b=KroHSicR26to81N4Zm8AMEA8oGNwOd9b3StgybP3FnYa694T2kKuE/VZW2utK5xBxO9i veWJPMQBwJfMi8zAdoJXEpQngzQQr85yhBlPuielqVAs1kq2PrCUc6lQDvnImsMCZSChz MMavT7r+fX+E8Cvb/vqlEvapp5JtakIgSjfDIMAyRnsFHgAWkygO025q6sRUKGAjDL8/h oitNIumw1v8AXb3ZzKH8rzXQkjQ6q1l3QTwGj9kp0aGhhNFhrcNibr46fML8rRA+Lzt3X cdMkFfPRZoLvmO5B7k4gzI3omQyRjg8FrOxo2ngpQuNy8yEqNq4s096VBY0pv4h5zWw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=r5nNzMcF; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ahme8KlX; dkim=pass header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=r5nNzMcF; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ahme8KlX; arc=none smtp.remote-ip=195.135.223.130 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63B2D606A31C for ; Wed, 18 Nov 2026 13:47:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 63B2D606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=r5nNzMcF; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ahme8KlX; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=r5nNzMcF; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ahme8KlX Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 47813222DD; Wed, 18 Nov 2026 13:47:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1795009630; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P29+0WSfDjivL0QnkfaQfvp/outg1KtB0aHDGFukhnc=; b=r5nNzMcFxtfKCzkdsqrQNtjAqYmmIo62cl7Xxr1aOWf4ewQFgO1GaSpRnwrX898O9Ft6+O Uv+Pz8x5K8gUa3Bled5PFMEyKLxSmscMCLzU4ehQ9ht6zJHEGQRMiErVawnSg9YRf9t4Px QuLmWVNFSUzGCrh+bCPE9rWptC3uveg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1795009630; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P29+0WSfDjivL0QnkfaQfvp/outg1KtB0aHDGFukhnc=; b=ahme8KlXHBzZ6/pvNKoSZbbNxUCEC7EeUhVqyDlkOJgJoQLA7fZVVH4lm164XNuK5TVdNk 77tpSO4aFLkTVbBQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=r5nNzMcF; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ahme8KlX DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1795009630; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P29+0WSfDjivL0QnkfaQfvp/outg1KtB0aHDGFukhnc=; b=r5nNzMcFxtfKCzkdsqrQNtjAqYmmIo62cl7Xxr1aOWf4ewQFgO1GaSpRnwrX898O9Ft6+O Uv+Pz8x5K8gUa3Bled5PFMEyKLxSmscMCLzU4ehQ9ht6zJHEGQRMiErVawnSg9YRf9t4Px QuLmWVNFSUzGCrh+bCPE9rWptC3uveg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1795009630; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P29+0WSfDjivL0QnkfaQfvp/outg1KtB0aHDGFukhnc=; b=ahme8KlXHBzZ6/pvNKoSZbbNxUCEC7EeUhVqyDlkOJgJoQLA7fZVVH4lm164XNuK5TVdNk 77tpSO4aFLkTVbBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C9D931334C; Wed, 18 Nov 2026 13:47:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id VEsWKF2s/WrLEgAAD6G6ig (envelope-from ); Wed, 18 Nov 2026 13:47:09 +0000 Date: Wed, 18 Nov 2026 14:47:09 +0100 Message-ID: <87h5hew8te.wl-tiwai@suse.de> From: Takashi Iwai To: Dmitriy Chumachenko Cc: Jaroslav Kysela , Takashi Iwai , Greg Kroah-Hartman , Sasha Levin , Oswald Buddenhagen , Mehul Rao , Ji'an Zhou , Norbert Szetei , , , Subject: Re: [PATCH v2] ALSA: pcm_oss: reject buffer reconfiguration while the stream is mmapped In-Reply-To: <20261118131945.27592-1-Dmitry.Chumachenko@cyberprotect.ru> References: <20261118131945.27592-1-Dmitry.Chumachenko@cyberprotect.ru> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/30.2 Mule/6.0 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spamd-Result: default: False [-12.51 / 50.00]; SUSE_INTERNAL_BYPASS(-9.00)[]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCPT_COUNT_TWELVE(0.00)[12]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVRCPT(0.00)[gmail.com,gmx.de]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[perex.cz,suse.com,linuxfoundation.org,kernel.org,gmx.de,gmail.com,doyensec.com,alsa-project.org,vger.kernel.org,linuxtesting.org]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[cyberprotect.ru:email,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:dkim] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spam-Flag: NO X-Spam-Score: -12.51 X-Spam-Level: X-Rspamd-Queue-Id: 47813222DD On Wed, 18 Nov 2026 14:19:45 +0100, Dmitriy Chumachenko wrote: > > During fuzz testing, the following issue was discovered. > > WARNING: CPU: 2 PID: 1734 at sound/core/pcm_native.c:3835 > snd_pcm_mmap_data_fault+0x47f/0x530 sound/core/pcm_native.c:3835 > > Modules linked in: > CPU: 2 PID: 1734 Comm: syz.1.352 Not tainted 6.1.187-syzkaller-00593-g063a81552262 #0 > RIP: 0010:snd_pcm_mmap_data_fault+0x47f/0x530 sound/core/pcm_native.c:3835 > > Call Trace: > > __do_fault+0x10d/0x480 mm/memory.c:4280 > do_cow_fault mm/memory.c:4661 [inline] > do_fault+0xa7a/0x1100 mm/memory.c:4762 > handle_pte_fault mm/memory.c:5031 [inline] > __handle_mm_fault+0xdf3/0x2e40 mm/memory.c:5173 > handle_mm_fault+0x2da/0xa60 mm/memory.c:5294 > do_user_addr_fault+0x4aa/0x1050 arch/x86/mm/fault.c:1338 > handle_page_fault arch/x86/mm/fault.c:1429 [inline] > exc_page_fault+0x98/0x1b0 arch/x86/mm/fault.c:1482 > asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:608 > > snd_pcm_oss_change_params() frees and reallocates the substream buffer, > and several OSS entry points reach it while the data area may already be > mmapped: snd_pcm_oss_mmap() and the SNDCTL_DSP_GETOSPACE/GETISPACE ioctls > (snd_pcm_oss_get_space()). > > For OSS streams snd_pcm_hw_params() skips the mmap_count guard > (!is_oss_stream), so the buffer is torn down under a live mapping. If the > reallocation then fails, the substream is left with runtime->dma_area == > NULL, and the next page fault on the stale mapping reaches > snd_pcm_mmap_data_fault() with no buffer, hitting the WARN_ON_ONCE(). > > Reject the reconfiguration in snd_pcm_oss_change_params_locked() when the > stream is already mmapped; this covers all callers (read/write already > bail out earlier on a non-zero mmap_count). The core WARN_ON_ONCE() is > left in place. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Dmitriy Chumachenko Well, if we want to restrict the hw_params with mmap completely, it's easier just drop the exception for OSS in the PCM core, instead: --- a/sound/core/pcm_native.c +++ b/sound/core/pcm_native.c @@ -778,7 +778,7 @@ static int hw_params_state_check(struct snd_pcm_substream *substream, case SNDRV_PCM_STATE_OPEN: case SNDRV_PCM_STATE_SETUP: case SNDRV_PCM_STATE_PREPARED: - if (check_mmap && !is_oss_stream(substream) && + if (check_mmap && atomic_read(&substream->mmap_count)) return -EBADFD; return 0; But, there must be some reason for this explicitly allowance for OSS (maybe some apps like the old game need it), and the above (and your) change would break it. So, if we really want to guarantee the compatibility for old existing applications, we need some other ways to check the buffer reallocation instead (e.g. disallow the buffer byte size change). Though, I'm not sure whether it's worth... thanks, Takashi