From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 498662EDD70 for ; Sun, 7 Jun 2026 07:27:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780817244; cv=none; b=X79wZRTxaKwFzndbEovHRHvgy9XrAz+PH4AyQLQRmTBifa/uXJtSUFK97pEgvI+oxnoXoCz5bXiTBA8HWjcgDvbj8wZNeFWojttCLKP+/zJLXKVp+5q/CV95EBQpZlajMocDRSjiKASlakwLTP+PMfb9QPCUoDG2pz0iBSKzWlI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780817244; c=relaxed/simple; bh=ELM/V8mLWLam82/ozs12Lgdw7MSyWYUa1St19CMZazI=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=UVhZWb4gQEvAKh2gOp/yRWKHuKqxewwfTEM0RHH+Pw4H+WyMl2FgO/ooN1eyg345MrTEDR3Hf3HVweAyquwUK0Q+PyohtYZFV4rsF4gFZP8Wic3f6aia+nL87XE7oWQasFmWHtLQNYuMRWu1B4LnfpBWf3I0xBeEOncPVUAql8o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=ZvOf+XU3; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=RQPoPvti; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=ZvOf+XU3; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=RQPoPvti; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ZvOf+XU3"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="RQPoPvti"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ZvOf+XU3"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="RQPoPvti" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5D8A7759DE; Sun, 7 Jun 2026 07:27:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780817241; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MN6X68wuE2NUb1dGCNERufXCHI2FEX0dQzvkBx9IHVI=; b=ZvOf+XU3Bpd969WDgDWJtIMeFbwgHgNP42zLT+zc0xtY8S4qmAiYzdxD9QEaGHKdEIowU7 ll1H7ymvDO2JcYjvfu9PQVED8G70FGjwWHqnMAyzeywWcF1mbI12obApj7OawKNcghWJHB EG7NOVySJcAvMfqIIUd6d4pfkSw4o68= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780817241; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MN6X68wuE2NUb1dGCNERufXCHI2FEX0dQzvkBx9IHVI=; b=RQPoPvtiRZedD12rMukvI/6bmIEQ+Fl2+Gs4PGB/s2icvcjgvRw7l0IN7Ewed+XdhUgkti 14hBNP5eKIDX7GDw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ZvOf+XU3; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=RQPoPvti DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780817241; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MN6X68wuE2NUb1dGCNERufXCHI2FEX0dQzvkBx9IHVI=; b=ZvOf+XU3Bpd969WDgDWJtIMeFbwgHgNP42zLT+zc0xtY8S4qmAiYzdxD9QEaGHKdEIowU7 ll1H7ymvDO2JcYjvfu9PQVED8G70FGjwWHqnMAyzeywWcF1mbI12obApj7OawKNcghWJHB EG7NOVySJcAvMfqIIUd6d4pfkSw4o68= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780817241; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MN6X68wuE2NUb1dGCNERufXCHI2FEX0dQzvkBx9IHVI=; b=RQPoPvtiRZedD12rMukvI/6bmIEQ+Fl2+Gs4PGB/s2icvcjgvRw7l0IN7Ewed+XdhUgkti 14hBNP5eKIDX7GDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3297F779A7; Sun, 7 Jun 2026 07:27:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id g9L8ClkdJWoOPQAAD6G6ig (envelope-from ); Sun, 07 Jun 2026 07:27:21 +0000 Date: Sun, 07 Jun 2026 09:27:20 +0200 Message-ID: <87h5nestd3.wl-tiwai@suse.de> From: Takashi Iwai To: Ruoyu Wang Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/8] ALSA: check snd_ctl_new1() return before dereferencing In-Reply-To: <20260607025613.3604194-1-ruoyuw560@gmail.com> References: <20260607025613.3604194-1-ruoyuw560@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/30.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Flag: NO X-Rspamd-Action: no action X-Spam-Level: X-Spamd-Result: default: False [-3.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; DWL_DNSWL_BLOCKED(0.00)[suse.de:dkim]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; RCVD_TLS_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:dkim,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 5D8A7759DE X-Spam-Score: -3.51 On Sun, 07 Jun 2026 04:56:05 +0200, Ruoyu Wang wrote: > > Several ALSA drivers dereference the pointer returned by snd_ctl_new1() > to adjust id.device, id.index, or store bookkeeping pointers before > calling snd_ctl_add(). snd_ctl_new1() can return NULL on allocation > failure, making these writes a NULL pointer dereference. > > This series adds NULL checks to all affected call sites found by static > analysis. > > Ruoyu Wang (8): > ALSA: es18xx: check control allocation before private data setup > ALSA: gus: check PCM volume control allocation > ALSA: cmipci: check S/PDIF control allocations > ALSA: es1938: check control allocation before private data setup > ALSA: ice1712: aureon: check CS8415 control allocation > ALSA: ice1712: check pro S/PDIF control allocations > ALSA: ice1724: check S/PDIF control allocations > ALSA: ymfpci: check S/PDIF control allocations Some of them seems to have been already applied or conflicting. Please rebase on the latest for-next branch of sound.git tree and resubmit. thanks, Takashi