From: Takashi Iwai <tiwai@suse.de>
To: wangdich9700@163.com
Cc: bo.liu@senarytech.com, perex@perex.cz, tiwai@suse.com,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
wangdicheng <wangdicheng@kylinos.cn>
Subject: Re: [PATCH v2] ALSA: hda/senary: Ensure EAPD is enabled during init
Date: Tue, 03 Mar 2026 10:45:37 +0100 [thread overview]
Message-ID: <87h5qxjlfi.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260303081516.583438-1-wangdich9700@163.com>
On Tue, 03 Mar 2026 09:15:16 +0100,
wangdich9700@163.com wrote:
>
> From: wangdicheng <wangdicheng@kylinos.cn>
>
> The driver sets spec->gen.own_eapd_ctl to take manual control of the
> EAPD (External Amplifier). However, senary_init does not turn on the
> EAPD, while senary_shutdown turns it off.
>
> Since the generic driver skips EAPD handling when own_eapd_ctl is set,
> the EAPD remains off after initialization (e.g., after resume), leaving
> the codec in a non-functional state.
>
> Explicitly call senary_auto_turn_eapd in senary_init to ensure the EAPD
> is enabled and the codec is functional.
>
> Signed-off-by: wangdicheng <wangdicheng@kylinos.cn>
> ---
>
> v1->v2:
> Change the email address to be consistent with the Signed-off-by line.
Thanks, applied now.
Takashi
prev parent reply other threads:[~2026-03-03 9:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 8:15 wangdich9700
2026-03-03 9:45 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h5qxjlfi.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=bo.liu@senarytech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=wangdich9700@163.com \
--cc=wangdicheng@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®