From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.parknet.co.jp (mail.parknet.co.jp [210.171.160.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78A6C28F5 for ; Mon, 1 Dec 2025 22:45:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.171.160.6 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764629130; cv=none; b=jY5Z+n80O+zXpOyJYGYXZsE5Xd3QoWqa6/6kMVgYqbiCCBPk9m6Eki2JM/1LnRlwCuIeSP9FiTG72WxjsZzTPSri2r2oK/S0UJYkBIrCWiTCaTK3WfA9SzI81G07FeonbCreHgKnXUCKZTaq11E7d6mjv/DYsqtftKDqOG/qjpw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764629130; c=relaxed/simple; bh=0Tmfhzq3vPTP94fX5r/jIUbjWE2Mkcqqs0EMtQBfC3U=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Ntst17y3fjm3UvaYMuhSF+3i1/UZJOFzf/W1gdynVjL94jNcIrQl9qCe+YHZRWx5MOWoUV6mfjqwO2g7L6OKAo3CXxRIyO4AbQGMpQF47w4APr4DBK4azmntfbeeCGiZEnnCeLWic/pu1//dQbh813N3C58G5LNJ0XNdEBNKyOg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mail.parknet.co.jp; spf=pass smtp.mailfrom=parknet.co.jp; dkim=pass (2048-bit key) header.d=parknet.co.jp header.i=@parknet.co.jp header.b=kh11riFV; dkim=permerror (0-bit key) header.d=parknet.co.jp header.i=@parknet.co.jp header.b=Klzv8Weg; arc=none smtp.client-ip=210.171.160.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mail.parknet.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=parknet.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=parknet.co.jp header.i=@parknet.co.jp header.b="kh11riFV"; dkim=permerror (0-bit key) header.d=parknet.co.jp header.i=@parknet.co.jp header.b="Klzv8Weg" Received: from ibmpc.myhome.or.jp (server.parknet.ne.jp [210.171.168.39]) by mail.parknet.co.jp (Postfix) with ESMTPSA id 16700209655C; Tue, 2 Dec 2025 07:45:20 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=parknet.co.jp; s=20250114; t=1764629120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/houz4nCpZSK+6G/j1S3l8JFye013e7YcdkJKEfVx5M=; b=kh11riFVyVSdIjlsBbIGT/PUPXrFSCCmHaz3I4T1NOGCP3HroOmObFkasYGx75t5lBN2lz u0zGO+8APhd1pNBs0sHiz7l8CFCX/l0WKO3PfrErLw8fYHXLlHrrr33FycppvqVuxS17v+ 9PHnw8DpgfgMlTiXWEIslwu/mzqLRCaggGATiA154mC/WE+klDWiWIKaqkzlwgM+X4OcK+ c9mcemUAk4XGVVgf/u1+XjOdggZNsAvspOuF+eOF6+jU7Vom9lTHvo/23pFqJgaRcVgdTV gp8+e4XRealZwtbxpBpuFW+QFLKkS2lRhm/SYuFPYRzbPFFcBcTyUKhq8LWBeg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=parknet.co.jp; s=20250114-ed25519; t=1764629120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/houz4nCpZSK+6G/j1S3l8JFye013e7YcdkJKEfVx5M=; b=Klzv8WeghP6cEW+cAysDLfIeTPhSSsbdVHMHCuJgRcum7nrpeDk0vbYJh9RujMtYQ80HXu 3NzVvC/MQRPsn6Dg== Received: from devron.myhome.or.jp (foobar@devron.myhome.or.jp [192.168.0.3]) by ibmpc.myhome.or.jp (8.18.1/8.18.1/Debian-7) with ESMTPS id 5B1MjI8R020746 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 2 Dec 2025 07:45:19 +0900 Received: from devron.myhome.or.jp (foobar@localhost [127.0.0.1]) by devron.myhome.or.jp (8.18.1/8.18.1/Debian-7) with ESMTPS id 5B1MjISU043865 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 2 Dec 2025 07:45:18 +0900 Received: (from hirofumi@localhost) by devron.myhome.or.jp (8.18.1/8.18.1/Submit) id 5B1MjIlk043864; Tue, 2 Dec 2025 07:45:18 +0900 From: OGAWA Hirofumi To: Lalit Shankar Chowdhury Cc: linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH] fat: remove unused parameter In-Reply-To: <20251201214403.90604-2-lalitshankarch@gmail.com> References: <20251201214403.90604-2-lalitshankarch@gmail.com> Date: Tue, 02 Dec 2025 07:45:18 +0900 Message-ID: <87h5u9vn29.fsf@mail.parknet.co.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Lalit Shankar Chowdhury writes: > Remove unused inode parameter from fat_cache_alloc(). > > Signed-off-by: Lalit Shankar Chowdhury Looks good. Acked-by: OGAWA Hirofumi > --- > fs/fat/cache.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/fat/cache.c b/fs/fat/cache.c > index 2af424e200b3..4cea26ddc161 100644 > --- a/fs/fat/cache.c > +++ b/fs/fat/cache.c > @@ -59,7 +59,7 @@ void fat_cache_destroy(void) > kmem_cache_destroy(fat_cache_cachep); > } > > -static inline struct fat_cache *fat_cache_alloc(struct inode *inode) > +static inline struct fat_cache *fat_cache_alloc(void) > { > return kmem_cache_alloc(fat_cache_cachep, GFP_NOFS); > } > @@ -149,7 +149,7 @@ static void fat_cache_add(struct inode *inode, struct fat_cache_id *new) > MSDOS_I(inode)->nr_caches++; > spin_unlock(&MSDOS_I(inode)->cache_lru_lock); > > - tmp = fat_cache_alloc(inode); > + tmp = fat_cache_alloc(); > if (!tmp) { > spin_lock(&MSDOS_I(inode)->cache_lru_lock); > MSDOS_I(inode)->nr_caches--; -- OGAWA Hirofumi