mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javierm@redhat.com>
To: Julius Werner <jwerner@chromium.org>
Cc: linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	Hugues Bruant <hugues.bruant@gmail.com>,
	Julius Werner <jwerner@chromium.org>,
	Brian Norris <briannorris@chromium.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Borislav Petkov <bp@alien8.de>,
	Tzung-Bi Shih <tzungbi@kernel.org>
Subject: Re: [PATCH v2] firmware: coreboot: Don't register a pdev if screen_info data is present
Date: Fri, 13 Sep 2024 23:43:55 +0200	[thread overview]
Message-ID: <87h6aj6xgk.fsf@minerva.mail-host-address-is-not-set> (raw)

Julius Werner <jwerner@chromium.org> writes:

Hello Julius,

>> +       /*
>> +        * On Coreboot systems, the advertised LB_TAG_FRAMEBUFFER entry
>> +        * in the Coreboot table should only be used if the payload did
>> +        * not pass a framebuffer information to the Linux kernel.
>
> nit: The official brand spelling is "coreboot", always lowercase (even
> at the start of a sentence). Not a big deal though.
>
> Reviewed-by: Julius Werner <jwerner@chromium.org>
>

Thanks for pointing that out, I wasn't aware. I just posted a v3 with
the proper coreboot spelling and your Reviewed-by tag collected.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat


             reply	other threads:[~2024-09-13 21:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-13 21:43 Javier Martinez Canillas [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-09-13 19:13 Javier Martinez Canillas
2024-09-13 21:04 ` Julius Werner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6aj6xgk.fsf@minerva.mail-host-address-is-not-set \
    --to=javierm@redhat.com \
    --cc=bp@alien8.de \
    --cc=briannorris@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hugues.bruant@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jwerner@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tzimmermann@suse.de \
    --cc=tzungbi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®