From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E004EB64D7 for ; Fri, 30 Jun 2023 08:29:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232535AbjF3I3g (ORCPT ); Fri, 30 Jun 2023 04:29:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232538AbjF3I3Q (ORCPT ); Fri, 30 Jun 2023 04:29:16 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 972F63C30 for ; Fri, 30 Jun 2023 01:29:03 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 324551F8C8; Fri, 30 Jun 2023 08:29:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1688113742; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sPfMVz9fzdH7759AhtIu8QxDAdvl6cZkVliQlQqx7wQ=; b=c63xGAKxYwGoLNjDTpFklyoYtQL4u1JhWkWpKthjYxVksw28ft8ZP1Q/ASPPxRyJaYBRn7 aL0H3IBihfZPECNSERtAnCjCAjqquseksqE7gVh/PtFkriNwanAGJNKVR5V89muB365ip2 dBSQ11g9Kpt3zp7VlCmLloNFD0s+H34= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1688113742; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sPfMVz9fzdH7759AhtIu8QxDAdvl6cZkVliQlQqx7wQ=; b=FN5pXLyno/TVUz+2leczgkywXRRdb8JuW3nt6uMUhO/HjKn3yBvswOCuqgRyvWiieqqF0B IpR2pHlZf+J8/gDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F2200138F8; Fri, 30 Jun 2023 08:29:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JBoTOk2SnmSITwAAMHmgww (envelope-from ); Fri, 30 Jun 2023 08:29:01 +0000 Date: Fri, 30 Jun 2023 10:29:01 +0200 Message-ID: <87h6qpcq0i.wl-tiwai@suse.de> From: Takashi Iwai To: "Luke D. Jones" Cc: tiwai@suse.com, perex@perex.cz, sbinding@opensource.cirrus.com, andy.chi@canonical.com, tangmeng@uniontech.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ALSA: hda/realtek: Add quirk for ASUS ROG GX650P In-Reply-To: <20230630043106.914724-2-luke@ljones.dev> References: <20230630043106.914724-1-luke@ljones.dev> <20230630043106.914724-2-luke@ljones.dev> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 30 Jun 2023 06:31:05 +0200, Luke D. Jones wrote: > > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -5883,7 +5883,7 @@ static void alc_fixup_headset_mode_alc255_no_hp_mic(struct hda_codec *codec, > struct alc_spec *spec = codec->spec; > spec->parse_flags |= HDA_PINCFG_HEADSET_MIC; > alc255_set_default_jack_type(codec); > - } > + } > else > alc_fixup_headset_mode(codec, fix, action); > } This change looks irrelevant. Could you drop it? If it needs to be fixed, put in another cleanup patch. thanks, Takashi