From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8B39C77B75 for ; Wed, 17 May 2023 14:57:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231174AbjEQO53 (ORCPT ); Wed, 17 May 2023 10:57:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229690AbjEQO5T (ORCPT ); Wed, 17 May 2023 10:57:19 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B41B86B4 for ; Wed, 17 May 2023 07:57:00 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8C80C22593; Wed, 17 May 2023 14:56:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1684335419; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CCW0GSVzxQIr22NMJ3VJJ2BVu5t1BOc63dfYXKfxO18=; b=d3l3jgdyGFM/s1sCSrw7VbD0oowiqXOHwcAFY+k/eVOFhofzYpLshx5Ux9n7tYKNF6qsz4 J1eCaGUEuEeEljIkUN3Xe5BTFyyuYT7rU27t+eOichhiRwKiCpY/ZPtvMt5kNfb/mGEIk+ WY1nSLZiN9yawymFCg9V7SeZe65ehDY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1684335419; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CCW0GSVzxQIr22NMJ3VJJ2BVu5t1BOc63dfYXKfxO18=; b=rvSYSb3NIVYjyn7W0VOR+nto5H5blgLZClSXb6sibCtryE7HbXVhO+0naD4qnv9KZniAR1 WoCY9qYXozr5DlCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5B73913358; Wed, 17 May 2023 14:56:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id QpUsFTvrZGQNdQAAMHmgww (envelope-from ); Wed, 17 May 2023 14:56:59 +0000 Date: Wed, 17 May 2023 16:56:58 +0200 Message-ID: <87h6sb0zwl.wl-tiwai@suse.de> From: Takashi Iwai To: Arnd Bergmann Cc: Jaroslav Kysela , Takashi Iwai , Arnd Bergmann , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ALSA: oss: avoid missing-prototype warnings In-Reply-To: <20230516195046.550584-2-arnd@kernel.org> References: <20230516195046.550584-1-arnd@kernel.org> <20230516195046.550584-2-arnd@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 16 May 2023 21:50:42 +0200, Arnd Bergmann wrote: > > From: Arnd Bergmann > > Two functions are defined and used in pcm_oss.c but also optionally > used from io.c, with an optional prototype. If CONFIG_SND_PCM_OSS_PLUGINS > is disabled, this causes a warning as the functions are not static > and have no prototype: > > sound/core/oss/pcm_oss.c:1235:19: error: no previous prototype for 'snd_pcm_oss_write3' [-Werror=missing-prototypes] > sound/core/oss/pcm_oss.c:1266:19: error: no previous prototype for 'snd_pcm_oss_read3' [-Werror=missing-prototypes] > > Avoid this by making the prototypes unconditional. > > Signed-off-by: Arnd Bergmann Thanks, applied now. Takashi