From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77D37C4332F for ; Mon, 21 Nov 2022 10:35:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229802AbiKUKf2 (ORCPT ); Mon, 21 Nov 2022 05:35:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230092AbiKUKfL (ORCPT ); Mon, 21 Nov 2022 05:35:11 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEAC8B08D6 for ; Mon, 21 Nov 2022 02:35:05 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 554F221AA1; Mon, 21 Nov 2022 10:35:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1669026904; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=po11InVlA78FEY3WlPUwwll4GVuOWXuBABURTMivemg=; b=DCiMa5bUOpAohqg34JiBbUR40BOly2yuZc0jTYZ0NbLlDXmeU0JvXnpl6PA7e9Yta2N42a LqS8DTzGSlKzNtQY3s2w+DuS6gf93UKOxjOyNH+Yk2T4c57j3QL6HtSD4biPW1SSQEIOds 4jM+4MG7OyUhgaFHwaC0Kfn5RE7zgL4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1669026904; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=po11InVlA78FEY3WlPUwwll4GVuOWXuBABURTMivemg=; b=iZpdmIHERrm/XkNSiYgwgETqNWc2F5uoNL3+vo+fz2VPS0znkxEWoIMwNI6EXj2rxwUNE3 zZCXJ5b82JFXezAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2B6531376E; Mon, 21 Nov 2022 10:35:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JDjZCVhUe2NOEwAAMHmgww (envelope-from ); Mon, 21 Nov 2022 10:35:04 +0000 Date: Mon, 21 Nov 2022 11:35:03 +0100 Message-ID: <87h6yswq7c.wl-tiwai@suse.de> From: Takashi Iwai To: Baisong Zhong Cc: , , , , , Subject: Re: [PATCH -next] ALSA: pcm: fix undefined behavior in bit shift for SNDRV_PCM_RATE_KNOT In-Reply-To: <20221121023329.2423665-1-zhongbaisong@huawei.com> References: <20221121023329.2423665-1-zhongbaisong@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Nov 2022 03:33:29 +0100, Baisong Zhong wrote: > > Shifting signed 32-bit value by 31 bits is undefined, so changing > significant bit to unsigned. The UBSAN warning calltrace like below: > > UBSAN: shift-out-of-bounds in sound/core/pcm_native.c:2676:21 > left shift of 1 by 31 places cannot be represented in type 'int' > ... > Call Trace: > > dump_stack_lvl+0x8d/0xcf > ubsan_epilogue+0xa/0x44 > __ubsan_handle_shift_out_of_bounds+0x1e7/0x208 > snd_pcm_open_substream+0x9f0/0xa90 > snd_pcm_oss_open.part.26+0x313/0x670 > snd_pcm_oss_open+0x30/0x40 > soundcore_open+0x18b/0x2e0 > chrdev_open+0xe2/0x270 > do_dentry_open+0x2f7/0x620 > path_openat+0xd66/0xe70 > do_filp_open+0xe3/0x170 > do_sys_openat2+0x357/0x4a0 > do_sys_open+0x87/0xd0 > do_syscall_64+0x34/0x80 > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Baisong Zhong > --- > include/sound/pcm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/sound/pcm.h b/include/sound/pcm.h > index 7b1a022910e8..ec28c2ec89de 100644 > --- a/include/sound/pcm.h > +++ b/include/sound/pcm.h > @@ -123,7 +123,7 @@ struct snd_pcm_ops { > #define SNDRV_PCM_RATE_384000 (1<<14) /* 384000Hz */ > > #define SNDRV_PCM_RATE_CONTINUOUS (1<<30) /* continuous range */ > -#define SNDRV_PCM_RATE_KNOT (1<<31) /* supports more non-continuos rates */ > +#define SNDRV_PCM_RATE_KNOT (1U<<31) /* supports more non-continuos rates */ Could you rather update all SNDRV_PCM_RATE_* to 1U? Otherwise it'll look inconsistent. thanks, Takashi