From: Thomas Gleixner <tglx@linutronix.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Martin Kaiser <martin@kaiser.cx>,
Ley Foon Tan <ley.foon.tan@intel.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
rfi@lists.rocketboards.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Jingoo Han <jingoohan1@gmail.com>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Toan Le <toan@os.amperecomputing.com>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH] PCI: altera-msi: Remove irq handler and data in one go
Date: Thu, 12 Nov 2020 19:19:18 +0100 [thread overview]
Message-ID: <87h7pumo9l.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20201112142657.GA1011805@bjorn-Precision-5520>
On Thu, Nov 12 2020 at 08:26, Bjorn Helgaas wrote:
> On Thu, Nov 12, 2020 at 02:50:42PM +0100, Thomas Gleixner wrote:
>> So I had a closer look and the reason why it only matters for the
>> chained handler case is that
>>
>> __irq_set_handler(..., is_chained = true, ...)
>>
>> starts up the interrupt immediately. So the order for this _must_ be:
>>
>> set_handler_data() -> set_handler()
>>
>> For regular interrupts it's really the mapping and allocation code which
>> does this long before the interrupt is started up. So the ordering does
>> not matter because the handler can't be reached before the full
>> setup is finished and the interrupt is actually started up.
>
> If the order truly doesn't matter here, maybe it's worth changing it
> to "set data, set handler" to avoid the need for a closer look to
> verify correctness and to make it harder to copy and paste to a place
> where it *does* matter?
Makes sense.
next prev parent reply other threads:[~2020-11-12 18:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-08 19:11 Martin Kaiser
2020-11-10 21:21 ` Bjorn Helgaas
2020-11-10 21:45 ` Bjorn Helgaas
2020-11-11 21:43 ` Martin Kaiser
2020-11-11 22:16 ` Bjorn Helgaas
2020-11-12 11:28 ` Thomas Gleixner
2020-11-12 13:50 ` Thomas Gleixner
2020-11-12 14:26 ` Bjorn Helgaas
2020-11-12 18:19 ` Thomas Gleixner [this message]
2020-11-11 22:01 ` [PATCH v2 1/2] PCI: altera-msi: Fix race in removing chained IRQ handler Martin Kaiser
2020-11-11 22:01 ` [PATCH v2 2/2] PCI: dwc: " Martin Kaiser
2020-11-12 22:10 ` [PATCH v3 1/3] PCI: altera-msi: remove chained IRQ handler and data in one go Martin Kaiser
2020-11-12 22:10 ` [PATCH v3 2/3] PCI: dwc: " Martin Kaiser
2020-11-12 22:10 ` [PATCH v3 3/3] PCI: xgene-msi: Fix race in installing chained irq handler Martin Kaiser
2020-11-13 16:54 ` [PATCH v3 1/3] PCI: altera-msi: remove chained IRQ handler and data in one go Bjorn Helgaas
2021-01-15 21:24 ` [PATCH v4 1/3] PCI: altera-msi: Remove " Martin Kaiser
2021-01-15 21:24 ` [PATCH v4 2/3] PCI: dwc: " Martin Kaiser
2021-01-15 21:24 ` [PATCH v4 3/3] PCI: xgene-msi: Fix race in installing chained irq handler Martin Kaiser
2021-01-18 15:49 ` [PATCH v4 1/3] PCI: altera-msi: Remove IRQ handler and data in one go Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7pumo9l.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=bhelgaas@google.com \
--cc=f.fainelli@gmail.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=helgaas@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=ley.foon.tan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=martin@kaiser.cx \
--cc=nsaenzjulienne@suse.de \
--cc=rfi@lists.rocketboards.org \
--cc=toan@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome