From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26FDEC43461 for ; Mon, 14 Sep 2020 17:47:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7F2A208B3 for ; Mon, 14 Sep 2020 17:47:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726031AbgINRrU (ORCPT ); Mon, 14 Sep 2020 13:47:20 -0400 Received: from out01.mta.xmission.com ([166.70.13.231]:41740 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726118AbgINMD5 (ORCPT ); Mon, 14 Sep 2020 08:03:57 -0400 Received: from in01.mta.xmission.com ([166.70.13.51]) by out01.mta.xmission.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1kHnCe-006GOo-TE; Mon, 14 Sep 2020 06:03:24 -0600 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95] helo=x220.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1kHnCd-0004kn-Vt; Mon, 14 Sep 2020 06:03:24 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: linmiaohe Cc: "christian.brauner\@ubuntu.com" , "akpm\@linux-foundation.org" , "peterz\@infradead.org" , "mingo\@kernel.org" , "christian\@kellner.me" , "surenb\@google.com" , "areber\@redhat.com" , "shakeelb\@google.com" , "cyphar\@cyphar.com" , "tglx\@linutronix.de" , "linux-kernel\@vger.kernel.org" References: <23352bc3a9914e79a0aa29bc63f830bd@huawei.com> Date: Mon, 14 Sep 2020 07:03:03 -0500 In-Reply-To: <23352bc3a9914e79a0aa29bc63f830bd@huawei.com> (linmiaohe's message of "Mon, 14 Sep 2020 01:38:24 +0000") Message-ID: <87h7s0va4o.fsf@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1kHnCd-0004kn-Vt;;;mid=<87h7s0va4o.fsf@x220.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX19DUNV8SW3I069vNxB+YtPgPAYKB1GiTRI= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH] fork: Use helper function mapping_allow_writable() in dup_mmap() X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org linmiaohe writes: > Eric W. Biederman wrote: >> Miaohe Lin writes: >> >>> Use helper function mapping_allow_writable() to atomic_inc >>> i_mmap_writable. >> >>Why? >> > > Because I think it's better to use the wrapper function instead of the > open hard code. My point is there is no context in this commit message. What makes it better to use the wrapper function? What makes the wrapper function the appropriate function to use? Why just this location? Why wasn't this change made when the wrapper function was introduced? I could probably read through the code and figure these things out but the description of the change should really include these things. Eric