From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02ED8C2BA19 for ; Thu, 23 Apr 2020 06:49:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC14221582 for ; Thu, 23 Apr 2020 06:49:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="vyEFmFLD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726870AbgDWGtR (ORCPT ); Thu, 23 Apr 2020 02:49:17 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:51497 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726696AbgDWGtR (ORCPT ); Thu, 23 Apr 2020 02:49:17 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1587624556; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=o+wVZ0HdkKdgihK3M0H7Bb0gg28lZpceeXg+Uha9THY=; b=vyEFmFLDuTklpG6caKpuXfBAOVXj/erkVYz+ZQQDsoEK4kfmBrteQ3JR2DRKWkxD3SZfMbSQ qMqCmF35KDRdDH869lQ+hOHOu6DlSan8yOKRTfq6msXneW01chJKGCGrYejSq7ucvVh4UPS4 OYit7mN8tr6gFv4fsuZJptN1Cd4= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5ea13a60.7f5db181c688-smtp-out-n03; Thu, 23 Apr 2020 06:49:04 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id CF365C43636; Thu, 23 Apr 2020 06:49:04 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id CC586C433CB; Thu, 23 Apr 2020 06:49:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org CC586C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Kai-Heng Feng Cc: yhchuang@realtek.com, "David S. Miller" , linux-wireless@vger.kernel.org (open list:REALTEK WIRELESS DRIVER (rtw88)), netdev@vger.kernel.org (open list:NETWORKING DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH 2/2] rtw88: Use udelay instead of usleep in atomic context References: <20200423063811.2636-1-kai.heng.feng@canonical.com> <20200423063811.2636-2-kai.heng.feng@canonical.com> Date: Thu, 23 Apr 2020 09:49:01 +0300 In-Reply-To: <20200423063811.2636-2-kai.heng.feng@canonical.com> (Kai-Heng Feng's message of "Thu, 23 Apr 2020 14:38:10 +0800") Message-ID: <87h7xan1cy.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kai-Heng Feng writes: > It's incorrect to use usleep in atomic context. > > Switch to a macro which uses udelay instead of usleep to prevent the issue. > > Signed-off-by: Kai-Heng Feng This fixes a regression, right? So there should be a Fixes line. Also I can't take this until patch 1 is in my tree. And I don't know who takes iopoll.h patches. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches