From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH 2/2] perf/x86/intel/bts: Fix the use of page_private()
Date: Wed, 11 Dec 2019 08:26:13 +0200 [thread overview]
Message-ID: <87h827cr96.fsf@ashishki-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20191211002334.GS2844@hirez.programming.kicks-ass.net>
Peter Zijlstra <peterz@infradead.org> writes:
>> static size_t buf_size(struct page *page)
>> {
>> - return 1 << (PAGE_SHIFT + page_private(page));
>> + return 1 << (PAGE_SHIFT + buf_nr_pages(page));
>
> Hurmph, shouldn't that be:
>
> return buf_nr_pages(page) * PAGE_SIZE;
>
> ?
True, that one's broken.
next prev parent reply other threads:[~2019-12-11 6:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 14:28 [PATCH 0/2] perf/x86/intel/bts: Small fixes Alexander Shishkin
2019-12-05 14:28 ` [PATCH 1/2] perf/x86/intel/bts: Remove a silly warning Alexander Shishkin
2019-12-10 15:29 ` Peter Zijlstra
2019-12-17 12:39 ` [tip: perf/urgent] perf/x86/intel/bts: Fix the use of page_private() tip-bot2 for Alexander Shishkin
2019-12-05 14:28 ` [PATCH 2/2] " Alexander Shishkin
2019-12-10 15:35 ` Peter Zijlstra
2019-12-11 0:23 ` Peter Zijlstra
2019-12-11 6:26 ` Alexander Shishkin [this message]
2019-12-10 17:40 ` [PATCH 0/2] perf/x86/intel/bts: Small fixes Peter Zijlstra
2019-12-11 11:33 ` Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h827cr96.fsf@ashishki-desk.ger.corp.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=acme@redhat.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®