From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9C5FCA9EC5 for ; Wed, 30 Oct 2019 21:10:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A001A20856 for ; Wed, 30 Oct 2019 21:10:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727069AbfJ3VKy (ORCPT ); Wed, 30 Oct 2019 17:10:54 -0400 Received: from smtp08.smtpout.orange.fr ([80.12.242.130]:47667 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727022AbfJ3VKy (ORCPT ); Wed, 30 Oct 2019 17:10:54 -0400 Received: from belgarion ([90.55.204.252]) by mwinf5d15 with ME id KxAo210045TFNlm03xAoN2; Wed, 30 Oct 2019 22:10:52 +0100 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Wed, 30 Oct 2019 22:10:52 +0100 X-ME-IP: 90.55.204.252 From: Robert Jarzmik To: Arnd Bergmann Cc: Daniel Mack , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linus Walleij , Lee Jones , Daniel Thompson , Jingoo Han , Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH 38/46] video: backlight: tosa: use gpio lookup table References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-38-arnd@arndb.de> X-URL: http://belgarath.falguerolles.org/ Date: Wed, 30 Oct 2019 22:10:48 +0100 In-Reply-To: <20191018154201.1276638-38-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 18 Oct 2019 17:41:53 +0200") Message-ID: <87h83qlz1j.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann writes: > The driver should not require a machine specific header. Change > it to pass the gpio line through a lookup table, and move the > timing generator definitions into the drivers itself. > > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > Cc: Bartlomiej Zolnierkiewicz > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fbdev@vger.kernel.org > Signed-off-by: Arnd Bergmann > > --- > I'm not overly confident that I got the correct device names > for the lookup table, it would be good if someone could > double-check. Ah the I2C and SPI devices querrying GPIOs ... unless someone does an actual test, this will probably be very regression prone ... Anyway : Acked-by: Robert Jarzmik Cheers. -- Robert