From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-896047-1517286964-2-3130681838617157965 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='au', MailFrom='org' X-Spam-charsets: X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517286964; b=TtdsBbG40ZLc2XWeFf2CsThwJ1QQn8kezDfKKg2N92fLwqM 7xo5qeUUNG1a63Z1UC/xtib58Bn7CKMorCTzeWPedpPlrpCAt6eQ405w9nzyq0Ih 4fB+VWhOQ9vCTIBzFWOiaNxU87wwe3H3PNTz6hxsyqzbDva6Rg8ORgTsfowxcLyA lDhLQT+NFsDT/2fZMpMGmRiFmk0Qn68yl6dBd8bEMizi5gMyP07RLUKNpPhrv47a DPCbgtOA/pzZTNNEhWXkMerS/X00vTXcY4hnpVz1BRD+mSDmH3eAYDJNtK4LZySD o4c3Ywjdg9CAv6WENxkeTaD4rdPnZhvnuY5jGOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:in-reply-to:references :date:message-id:mime-version:content-type:sender:list-id; s= arctest; t=1517286964; bh=glTWAsk+BF5zD5tPnuwJXNgc/ERdBxpZDnDzmf RTwsU=; b=ZBGUn5i1GC/lLznL2QVrHZYzq0qQ9F3j7l6H1+WATuNif/w1W7gZru XbOXYffC5L/expmdPT2Y9iU/AF4YpTQE6cIcrkkT8oMdfmeh8Y+dmJ7mfQcr3A7O CeUaonpC10E682E+HLg7nJFsfze/oBM6yeJNgEE++kPdRHkhmM1Y/x19/TvBmZkb HpEiOQcbpTSs6MeU4hBIiv6Gcezgd5EHxHXNYJY+L5gjjvBh7iF5l6rmzHQSHW0h KexG3gNwjx5jB5Qzdk1LYFOvI7Vmw4d0F0qK35j5Jh1IYm8Q2acQoRDmbLG6SJQj u8ZdN+MC82tOQ1GNQyQzRBhY4wqhNfaw== ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=ellerman.id.au; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=ellerman.id.au header.result=pass header_is_org_domain=yes Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=ellerman.id.au; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=ellerman.id.au header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752232AbeA3EgA (ORCPT ); Mon, 29 Jan 2018 23:36:00 -0500 Received: from ozlabs.org ([103.22.144.67]:59269 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752076AbeA3EgA (ORCPT ); Mon, 29 Jan 2018 23:36:00 -0500 From: Michael Ellerman To: alexander.levin@verizon.com Cc: "linux-kernel\@vger.kernel.org" , "stable\@vger.kernel.org" , Nicholas Piggin Subject: Re: [PATCH AUTOSEL for 3.18 36/40] powerpc/xmon: Avoid tripping SMP hardlockup watchdog In-Reply-To: <20171213134453.4sbmin2tjprrjnty@sasha-lappy> References: <20171213015905.7059-1-alexander.levin@verizon.com> <20171213015905.7059-36-alexander.levin@verizon.com> <87lgi6ai40.fsf@concordia.ellerman.id.au> <20171213134453.4sbmin2tjprrjnty@sasha-lappy> Date: Tue, 30 Jan 2018 15:35:54 +1100 Message-ID: <87h8r47yl1.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: alexander.levin@verizon.com writes: > On Thu, Dec 14, 2017 at 12:10:39AM +1100, Michael Ellerman wrote: >>alexander.levin@verizon.com writes: >> >>> From: Nicholas Piggin >>> >>> [ Upstream commit 064996d62a33ffe10264b5af5dca92d54f60f806 ] >>> >>> The SMP hardlockup watchdog cross-checks other CPUs for lockups, which >>> causes xmon headaches because it's assuming interrupts hard disabled >>> means no watchdog troubles. Try to improve that by calling >>> touch_nmi_watchdog() in obvious places where secondaries are spinning. >>> >>> Also annotate these spin loops with spin_begin/end calls. >> >>These macros didn't exist until 4.13, and haven't been backported AFAIK. > > But the touch_nmi_watchdog() bits are something we want in stable, right? I don't think you need them unless you've also back ported arch/powerpc/kernel/watchdog.c, which I don't think you have. Maybe Nick can confirm? Also, I thought 3.18 was EOL? cheers