mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [VFS PATCH] constify more dcache.h inlined helpers.
Date: Fri, 20 Oct 2017 11:41:17 +1100	[thread overview]
Message-ID: <87h8uufy6q.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <8760e6veh6.fsf@notabene.neil.brown.name>

[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]

On Wed, Aug 02 2017, NeilBrown wrote:

> Many of the inlines in dcache.h were changed to accept
> const struct pointers in commit f0d3b3ded999 ("constify dcache.c
> inlined helpers where possible").
> This patch allows 'const' in a couple that were added since then.
>
> Signed-off-by: NeilBrown <neilb@suse.com>

Ping ... should I be sending this somewhere else?  Is there a problem
with it?

Thanks,
NeilBrown


> ---
>  include/linux/dcache.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/dcache.h b/include/linux/dcache.h
> index aae1cdb76851..66ca42b1935b 100644
> --- a/include/linux/dcache.h
> +++ b/include/linux/dcache.h
> @@ -358,7 +358,7 @@ static inline void dont_mount(struct dentry *dentry)
>  
>  extern void __d_lookup_done(struct dentry *);
>  
> -static inline int d_in_lookup(struct dentry *dentry)
> +static inline int d_in_lookup(const struct dentry *dentry)
>  {
>  	return dentry->d_flags & DCACHE_PAR_LOOKUP;
>  }
> @@ -486,7 +486,7 @@ static inline bool d_really_is_positive(const struct dentry *dentry)
>  	return dentry->d_inode != NULL;
>  }
>  
> -static inline int simple_positive(struct dentry *dentry)
> +static inline int simple_positive(const struct dentry *dentry)
>  {
>  	return d_really_is_positive(dentry) && !d_unhashed(dentry);
>  }
> -- 
> 2.14.0.rc0.dirty

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2017-10-20  0:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-02  3:24 NeilBrown
2017-10-20  0:41 ` NeilBrown [this message]
2017-10-20  3:33   ` Al Viro
2017-10-20  9:39     ` NeilBrown
2017-12-18 23:15     ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8uufy6q.fsf@notabene.neil.brown.name \
    --to=neilb@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®